From: Greg KH <gregkh@linuxfoundation.org>
To: zhangqiumiao1@huawei.com
Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tty: resolve loopback wait problem for aging serial port
Date: Wed, 30 Dec 2020 13:49:14 +0100 [thread overview]
Message-ID: <X+x3Soqf6D6XzuxY@kroah.com> (raw)
In-Reply-To: <1609331946-10165-1-git-send-email-zhangqiumiao1@huawei.com>
On Wed, Dec 30, 2020 at 08:39:06PM +0800, zhangqiumiao1@huawei.com wrote:
> From: Qiumiao Zhang <zhangqiumiao1@huawei.com>
>
> Because serial port is low-speed device, serial port writing will be suspended
> when the buffer of driver layer is full due to serial port aging. The concrete
> representation is n_tty_write blocking in the process of wait_woken, the process
> of writing serial port exists without feedback, and becomes a zombie process.
> So for serial port, set the timeout value of wait_woken function to 60s. Wake up
> and flush the buffer after timeout.
>
> Signed-off-by: Qiumiao Zhang <zhangqiumiao1@huawei.com>
> ---
> drivers/tty/n_tty.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
What changed from v1? Always put that below the --- line as the
documentation asks you to do so.
Please fix up and submit a v3.
thanks,
greg k-h
parent reply other threads:[~2020-12-30 12:48 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1609331946-10165-1-git-send-email-zhangqiumiao1@huawei.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+x3Soqf6D6XzuxY@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangqiumiao1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®