From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B1CC433DB for ; Wed, 30 Dec 2020 12:50:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9366221FA for ; Wed, 30 Dec 2020 12:50:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726795AbgL3Mt7 (ORCPT ); Wed, 30 Dec 2020 07:49:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:50800 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726605AbgL3Mt6 (ORCPT ); Wed, 30 Dec 2020 07:49:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 102EA221FA; Wed, 30 Dec 2020 12:49:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609332557; bh=N5O6ImIkhpBZXKVxzeXm2qESd/kJs56wLovgR0WzzvA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WfBzYsy1U4kWCSu15T6F6GHLAulAxHU6NStTDDann3jT9gNRpDyoXovshTBVH5Zie BYx60T/7tNBZg0OrERa8shK1Nyh9dOtc1Qx9vSJGdpVZMQYU53fvjmm8+uHixYnQ1S NnPH1SydXvkM4FY8O0bytIAsLNKaAaB7Xfx8px8k= Date: Wed, 30 Dec 2020 13:50:44 +0100 From: Greg Kroah-Hartman To: Markus Elfring Cc: Xiaolei Wang , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner , Mark Brown , "Rafael J. Wysocki" , Julia Lawall Subject: Re: [PATCH v3] regmap: debugfs: Fix a memory leak when calling regmap_attach_dev Message-ID: References: <20201229105046.41984-1-xiaolei.wang@windriver.com> <1503f5fa-1ad6-7675-6e02-6dc1eb04c1de@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1503f5fa-1ad6-7675-6e02-6dc1eb04c1de@web.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 30, 2020 at 01:01:42PM +0100, Markus Elfring wrote: > > Thank you very much, very good suggestion, > > Thanks for another positive feedback. > > > > do I need to re-send a patch to fix this problem, or modify the previous patch and send it again? > > Please convince the involved contributors to integrate a corrected patch version. > > * Better indentation. > > * … > >> + if (!map->debugfs_name) > >> + kfree(map->debugfs_name); > > Would this questionable null pointer check result in a memory leak? Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot