From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D90EC433DB for ; Wed, 30 Dec 2020 21:21:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DB4220B1F for ; Wed, 30 Dec 2020 21:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726337AbgL3VVF (ORCPT ); Wed, 30 Dec 2020 16:21:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726197AbgL3VVF (ORCPT ); Wed, 30 Dec 2020 16:21:05 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1F0CC061573; Wed, 30 Dec 2020 13:20:24 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E6D243E; Wed, 30 Dec 2020 22:20:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1609363221; bh=FzFPXZYwcTCYXVGfwAKemFzBPJlkDh8ZhIQZqZzJjVU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q4z6r/TQp6gZHFP9t3UB5xELh5lTXNlc+QaldjORLKZ93lbgtY1+/DZh9aJfNLG0u 7QZSTECowBlpWUNtYKv8xL9IQSt44ml95u02EHSlW772eM7Miv39+xfIVHGoDjQzR9 7oezsDE2tIMw1qx3MiPB2K/54UMXZDhHAqekyeQs= Date: Wed, 30 Dec 2020 23:20:09 +0200 From: Laurent Pinchart To: Pavel Machek Cc: sakari.ailus@linux.intel.com, andy.shevchenko@gmail.com, mchehab+huawei@kernel.org, yong.zhi@intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: ipu3-cio2: Fix mbus_code processing in cio2_subdev_set_fmt() Message-ID: References: <20201230125550.GA14074@duo.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201230125550.GA14074@duo.ucw.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, Thank you for the patch. On Wed, Dec 30, 2020 at 01:55:50PM +0100, Pavel Machek wrote: > Loop was useless as it would always exit on the first iteration. Fix > it with right condition. > > Signed-off-by: Pavel Machek (CIP) > Fixes: a86cf9b29e8b ("media: ipu3-cio2: Validate mbus format in setting subdev format") Tested-by: Laurent Pinchart Reviewed-by: Laurent Pinchart > index 36e354ecf71e..e8ea69d30bfd 100644 > --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c > +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > @@ -1269,7 +1269,7 @@ static int cio2_subdev_set_fmt(struct v4l2_subdev *sd, > fmt->format.code = formats[0].mbus_code; > > for (i = 0; i < ARRAY_SIZE(formats); i++) { > - if (formats[i].mbus_code == fmt->format.code) { > + if (formats[i].mbus_code == mbus_code) { > fmt->format.code = mbus_code; > break; > } > -- Regards, Laurent Pinchart