From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C15EC5519F for ; Sat, 14 Nov 2020 12:55:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3743222226 for ; Sat, 14 Nov 2020 12:55:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pbeWEVEt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726854AbgKNMzx (ORCPT ); Sat, 14 Nov 2020 07:55:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:41790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726725AbgKNMzw (ORCPT ); Sat, 14 Nov 2020 07:55:52 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1A149221EB; Sat, 14 Nov 2020 12:55:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605358551; bh=HCbruWEYiz+X+jHd1lETN3LqMLkj5XSplNUFQhbcOs0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pbeWEVEth40MQOYEUSrHWHvwpzUVF3JD3Y3eP1r1wUUyfJrSPdjak5Nby6fh2ykUc MgDH0lg24eDO+t4AvDYs0LCjJl3wO5ZlV+4COPlwAPfJweiyCI0vJjBgy5VnlDrJ5/ wjjAZbDhOkBkAjOtXCW4NwWKwhJclCn6/QQ9kWHQ= Date: Sat, 14 Nov 2020 13:56:46 +0100 From: Greg Kroah-Hartman To: Lucas Tanure Cc: Bastien Nocera , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: apple-mfi-fastcharge: Use devm_kzalloc and simplify the code Message-ID: References: <20201114124249.634234-1-tanure@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201114124249.634234-1-tanure@linux.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 14, 2020 at 12:42:49PM +0000, Lucas Tanure wrote: > Signed-off-by: Lucas Tanure I can't take patches without any changelog text, sorry. > --- > drivers/usb/misc/apple-mfi-fastcharge.c | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) > > diff --git a/drivers/usb/misc/apple-mfi-fastcharge.c b/drivers/usb/misc/apple-mfi-fastcharge.c > index 9de0171b5177..de86e389a008 100644 > --- a/drivers/usb/misc/apple-mfi-fastcharge.c > +++ b/drivers/usb/misc/apple-mfi-fastcharge.c > @@ -178,16 +178,13 @@ static int mfi_fc_probe(struct usb_device *udev) > { > struct power_supply_config battery_cfg = {}; > struct mfi_device *mfi = NULL; > - int err; > > if (!mfi_fc_match(udev)) > return -ENODEV; > > - mfi = kzalloc(sizeof(struct mfi_device), GFP_KERNEL); > - if (!mfi) { > - err = -ENOMEM; > - goto error; > - } > + mfi = devm_kzalloc(&udev->dev, sizeof(*mfi), GFP_KERNEL); > + if (!mfi) > + return -ENOMEM; > > battery_cfg.drv_data = mfi; > > @@ -197,8 +194,7 @@ static int mfi_fc_probe(struct usb_device *udev) > &battery_cfg); > if (IS_ERR(mfi->battery)) { > dev_err(&udev->dev, "Can't register battery\n"); > - err = PTR_ERR(mfi->battery); > - goto error; > + return PTR_ERR(mfi->battery); > } > > mfi->udev = usb_get_dev(udev); > @@ -206,9 +202,6 @@ static int mfi_fc_probe(struct usb_device *udev) > > return 0; > > -error: > - kfree(mfi); > - return err; > } > > static void mfi_fc_disconnect(struct usb_device *udev) > @@ -220,7 +213,7 @@ static void mfi_fc_disconnect(struct usb_device *udev) > power_supply_unregister(mfi->battery); > dev_set_drvdata(&udev->dev, NULL); > usb_put_dev(mfi->udev); > - kfree(mfi); > + devm_kfree(&udev->dev, mfi); Are you sure about this? And what's wrong with the existing code? Using the devm_*() variants seems like a "cleanup", but it's not always the case. thanks, greg k-h