mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Hui Su <sh_def@163.com>,
	mingo@redhat.com, jack@suse.cz, akpm@linux-foundation.org,
	neilb@suse.de, trond.myklebust@hammerspace.com,
	liuzhiqiang26@huawei.com, tytso@mit.edu, cai@lca.pw,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trace: fix potenial dangerous pointer
Date: Tue, 24 Nov 2020 12:09:02 -0500	[thread overview]
Message-ID: <X70+Ll+L2ksoeCMv@mtj.duckdns.org> (raw)
In-Reply-To: <20201124120523.34a59eed@gandalf.local.home>

On Tue, Nov 24, 2020 at 12:05:23PM -0500, Steven Rostedt wrote:
> On Wed, 25 Nov 2020 00:52:05 +0800
> Hui Su <sh_def@163.com> wrote:
> 
> > The bdi_dev_name() returns a char [64], and
> > the __entry->name is a char [32].
> > 
> > It maybe dangerous to TP_printk("%s", __entry->name)
> > after the strncpy().
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 
> This should go through the tree that has the code that uses these
> tracepoints.

Acked-by: Tejun Heo <tj@kernel.org>

Andrew, can you please route this one?

Thanks.

-- 
tejun

  reply	other threads:[~2020-11-24 17:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201124165205.GA23937@rlk>
2020-11-24 17:05 ` Steven Rostedt
2020-11-24 17:09   ` Tejun Heo [this message]
2020-11-25 12:05     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X70+Ll+L2ksoeCMv@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cai@lca.pw \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuzhiqiang26@huawei.com \
    --cc=mingo@redhat.com \
    --cc=neilb@suse.de \
    --cc=rostedt@goodmis.org \
    --cc=sh_def@163.com \
    --cc=trond.myklebust@hammerspace.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®