From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD343C63777 for ; Wed, 25 Nov 2020 07:16:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B73920DD4 for ; Wed, 25 Nov 2020 07:16:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WofC9uB4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727758AbgKYHQy (ORCPT ); Wed, 25 Nov 2020 02:16:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:47450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725306AbgKYHQy (ORCPT ); Wed, 25 Nov 2020 02:16:54 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61925208B8; Wed, 25 Nov 2020 07:16:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1606288606; bh=gUkyGSpZPzozZHqhwoqFTigIg2G04BKThv9/K6m/Mhw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WofC9uB4axUAU+F4T3jQi1jeNLbCInez1DEgfDag10sFVJl5/HEtUwZZQInKZbobo eAoOmQyS5UPL+Mz2kwXqMKuOth+Km5W481wazbrcMChouMXxww/lhO5kgSPEGLxa6U zGFvfebJ34BivXSwv1sMuXVr7+84G3U/6IIHBqYE= Date: Wed, 25 Nov 2020 08:17:52 +0100 From: Greg KH To: Joe Perches Cc: Tiezhu Yang , Andrew Morton , Andy Whitcroft , Sasha Levin , linux-kernel@vger.kernel.org, Xuefeng Li Subject: Re: [PATCH RESEND] checkpatch: Do not check git commit description style when backport the upstream commit Message-ID: References: <1606275347-19297-1-git-send-email-yangtiezhu@loongson.cn> <995e0acb-c219-ea00-f078-7582516e25de@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2020 at 08:24:15PM -0800, Joe Perches wrote: > On Wed, 2020-11-25 at 12:08 +0800, Tiezhu Yang wrote: > > On 11/25/2020 11:51 AM, Joe Perches wrote: > > > On Wed, 2020-11-25 at 11:35 +0800, Tiezhu Yang wrote: > > > > When backport the upstream commit to the internal LTS kernel version, > > > > we usually use the following description [1] [2]: > > > > > > > > [ Upstream commit cc6528bc9a0c901c83b8220a2e2617f3354d6dd9 ] > > > > or > > > > commit c51f8f88d705e06bd696d7510aff22b33eb8e638 upstream. > > > Internal to what? > > > > > > If it's your own internal build system, I think you should > > > keep your own local patch to checkpatch. > > > > > > I don't see why the kernel version should accept it. > > > > > > Is this style used by anyone else? > > > > AFAIK, this style is only used in the stable tree, for example: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.9.y&id=c68a9ca7ca33f1020cca97e4e935c2154bec37c7 > > Greg?/Sasha? > > https://lore.kernel.org/lkml/995e0acb-c219-ea00-f078-7582516e25de@loongson.cn/T/#m2f3d87bd985bf3d4d7b63f1fa4f0490baa01119b > > Is this in your scripts? My scripts put this into a patch when applying it to the stable tree, and so do Sasha's. I don't know why checkpatch would care about this as that's not used for this workflow at all. > Is this something you want/use? I wouldn't use it, and I doubt anyone else would. thanks, greg k-h