From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E750C5519F for ; Fri, 20 Nov 2020 09:50:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C250A204EF for ; Fri, 20 Nov 2020 09:50:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="l5zibdCR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727118AbgKTJuF (ORCPT ); Fri, 20 Nov 2020 04:50:05 -0500 Received: from mx2.suse.de ([195.135.220.15]:34002 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbgKTJuF (ORCPT ); Fri, 20 Nov 2020 04:50:05 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1605865804; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1xs/FyEHbTR25nH7LU7ymZu1HNJyJ3XDN8eI7fh5D2s=; b=l5zibdCR+QfC0tlu+B6KjUOtYv+PGV5renAYAAYNjlen1woKlzLTKTGGHHN8Rv6DakcjNd Ldp9fuRFQ9jgwHCyqvSVooh9YcLE85ecvcBa2y4fadePrjAc4mLKbpGSG0b4y6cC1tWTQj Bav2Lvf/VSxANxvgjvVS/I1uAlqykjI= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3485FAC60; Fri, 20 Nov 2020 09:50:04 +0000 (UTC) Date: Fri, 20 Nov 2020 10:50:03 +0100 From: Petr Mladek To: Hui Su Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, 0x7f454c46@gmail.com, jroedel@suse.de, akpm@linux-foundation.org, jannh@google.com, mark.mossberg@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/dumpstack: make show_trace_log_lvl() static Message-ID: References: <20201113133943.GA136221@rlk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201113133943.GA136221@rlk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 2020-11-13 21:39:43, Hui Su wrote: > show_trace_log_lvl() won't be used by other files, so > make it static and remove the declaration from the header > file. > > Signed-off-by: Hui Su I would make sense to add: Fixes: 16d1cb0bc43642a4d9 ("x86/dumpstack: Unify show_regs()") Othrewise, it looks good: Reviewed-by: Petr Mladek Best Regards, Petr