From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Christoph Hellwig <hch@lst.de>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Namjae Jeon <linkinjeon@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build
Date: Mon, 30 Nov 2020 12:15:30 +0900 [thread overview]
Message-ID: <X8Rj0s/Emv9Qmv3d@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <5b015b83-f183-526a-94e7-029f4c98b30b@infradead.org>
On (20/11/29 18:00), Randy Dunlap wrote:
> On 11/29/20 5:44 PM, Sergey Senozhatsky wrote:
> > Some functions that are declared when CONFIG_POSIX_ACL is defined
> > are not declared when CONFIG_POSIX_ACL is not defined. Add the
> > missing ones:
> > set_posix_acl(), posix_acl_update_mode(), get_cached_acl(),
> > get_cached_acl_rcu(), set_cached_acl(), forget_cached_acl().
> >
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>
> Hi,
>
> I can't find CONFIG_POSIX_ACL in the kernel source tree.
> Should it be CONFIG_FS_POSIX_ACL ?
Oh, yes, CONFIG_POSIX_ACL. My bad.
> How did you test this?
You know what - scratch this patch. Sorry for the noise.
Some of the posix_acl.h functions are guarded by ifdef/ifndef
CONFIG_FS_POSIX_ACL, and some are not. This can break the build
if the code in question doesn't use ifdef CONFIG_FS_POSIX_ACL
(which happens with our code). But this patch is not enough,
apparently, we need to add ifdef CONFIG_FS_POSIX_ACL to our
code anyway, because of, for instance, posix_acl_alloc() which
is undefined for !FS_POSIX_ACL builds. Sorry for the noise.
-ss
next prev parent reply other threads:[~2020-11-30 3:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 1:44 Sergey Senozhatsky
2020-11-30 2:00 ` Randy Dunlap
2020-11-30 3:15 ` Sergey Senozhatsky [this message]
2020-11-30 3:17 ` Sergey Senozhatsky
2020-11-30 3:37 ` Sergey Senozhatsky
2020-11-30 4:00 ` Randy Dunlap
2020-11-30 13:09 ` Andreas Gruenbacher
2020-11-30 13:13 ` Andreas Gruenbacher
2020-11-30 13:28 ` Sergey Senozhatsky
2020-11-30 6:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8Rj0s/Emv9Qmv3d@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=gustavo@embeddedor.com \
--cc=hch@lst.de \
--cc=linkinjeon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®