From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E64DCC63777 for ; Mon, 30 Nov 2020 15:54:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 938A7205F4 for ; Mon, 30 Nov 2020 15:54:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mjqR2XRw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726868AbgK3Px6 (ORCPT ); Mon, 30 Nov 2020 10:53:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbgK3Px6 (ORCPT ); Mon, 30 Nov 2020 10:53:58 -0500 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8C47C0613CF; Mon, 30 Nov 2020 07:53:17 -0800 (PST) Received: by mail-pl1-x642.google.com with SMTP id x15so6709622pll.2; Mon, 30 Nov 2020 07:53:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XL+gEtLKF5TbtWhyDLeu71fgcb40bHQjbGEt03J+KJQ=; b=mjqR2XRw0sTw8mfSziT6pQr3iztcPuVSjvpyvfaKwfseqpGTxcvE79mhP820ksdGKc CY7d9iuh895rz38mvIN4uTna7isa9zaeZnUTas9Gd7bBr+TqLXiHm2n4nPmtZORYZyJ4 rjmeGklmItUURRQ2i3HbLKOEI4LhlUPa3Kh1bCRG1yfzxWQ8QjUbwz2xjZXWyaJcX0Km lM1Tt2RgzL4GJ3HOtLtXEERqksoyXfNNnrHsnt6GE3qVxTg3em8FQLzpu7O1FPM60YZy 4aIc6onqGeBo+aMF8eCPRsq8l8WY0bEwLo29umN09V7ZL46fR4g2+gRv5p+02WyPLYTd 7DdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XL+gEtLKF5TbtWhyDLeu71fgcb40bHQjbGEt03J+KJQ=; b=cXM7tT2I1r/nydfKGLGwJRJ9BWoefR7KiyThy1iaDJtMlpmDGDv+89INNc0Q/PgCpS 0hsnKy5ulq3E18E9IcqHHydoelwVInLq1sRXZ2YplDy/O0WE61IafOuYOwMpv81MvoOl jLTRztmKMurbasKqDwxJjeU0UHuFbEeaAKeY+xZ2lNwbDxfpYon1KyVE/gQTzrg2jLS4 ybdKf6fKdR9/kH1F57KEjolfwOlkddwuYw57LhuZ2wE98sOFM5kv7hUfg6a12s2Yjnx3 CnMheeu7ADzdm1fnSklQzqb53jTJWStA1EryWYpyHyzcwpiqbcRLyjhu1ciLuwlwwUxw pOLA== X-Gm-Message-State: AOAM533rvP/K0H8jPH+GbN/v+U4CYanHj5GlvYa+/BfwYpgfMIP3V33Y KLZq7DJApoFVdl+o4/DQ8Cg= X-Google-Smtp-Source: ABdhPJxiVoJPKZalI/tDDI2rv1drqlE/C7sDL3EpVHr85z2lOu1xRvzNmy67S8eDuDPPZFaAfWPoSQ== X-Received: by 2002:a17:90a:4405:: with SMTP id s5mr26762160pjg.219.1606751597508; Mon, 30 Nov 2020 07:53:17 -0800 (PST) Received: from localhost ([2409:10:2e40:5100:6e29:95ff:fe2d:8f34]) by smtp.gmail.com with ESMTPSA id m11sm17625628pfa.24.2020.11.30.07.53.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 07:53:16 -0800 (PST) Date: Tue, 1 Dec 2020 00:53:14 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: Lukas Bulwahn , Sergey Senozhatsky , Steven Rostedt , John Ogness , Nathan Chancellor , Nick Desaulniers , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, kernel-janitors@vger.kernel.org, linux-safety@lists.elisa.tech Subject: Re: [PATCH] printk: remove obsolete dead assignment Message-ID: References: <20201130124915.7573-1-lukas.bulwahn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (20/11/30 16:37), Petr Mladek wrote: > On Mon 2020-11-30 13:49:15, Lukas Bulwahn wrote: [..] > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > > index f279d4fbd9dd..6e4e38b7cd91 100644 > > --- a/kernel/printk/printk.c > > +++ b/kernel/printk/printk.c > > @@ -741,7 +741,6 @@ static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from) > > if (LOG_FACILITY(u) != 0) > > facility = LOG_FACILITY(u); > > endp++; > > - len -= endp - line; > > line = endp; > > } > > } > > Yup, it was used to write the trailing '\0'. But it is done earlier > now. So, it is not longer needed. > > Reviewed-by: Petr Mladek > > Best Regards, > Petr > > PS: I'll give it few days just in case anyone else would want to > review it. I'll push it then unless anyone complains. FWIW, looks good to me Reviewed-by: Sergey Senozhatsky -ss