From: Greg KH <gregkh@linuxfoundation.org>
To: jiladahe1997 <972931182@qq.com>
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, linux-imx@nxp.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty/serial/imx: Enable TXEN bit in imx_poll_init().
Date: Tue, 1 Dec 2020 11:11:03 +0100 [thread overview]
Message-ID: <X8YWt5TGlcI93E8e@kroah.com> (raw)
In-Reply-To: <tencent_20B71295BC0C2FCB5807D81BC045ED802C06@qq.com>
On Tue, Dec 01, 2020 at 09:52:49AM +0800, jiladahe1997 wrote:
> From: Mingrui Ren <972931182@qq.com>
>
> As described in Documentation, poll_init() is called by kgdb to initialize
> hardware which support both poll_put_char() and poll_get_char().
>
> It's necessary to enable TXEN bit, otherwise, it will cause hardware fault
> and kernel panic when calling imx_poll_put_char().
>
> Generally, if use /dev/ttymxc0 as kgdb console as well as system
> console, ttymxc0 is initialized early by system console which does enable TXEN
> bit.But when use /dev/ttymxc1 as kgbd console, ttymxc1 is only initialized by
> imx_poll_init() cannot enable the TXEN bit, which will cause kernel panic.
>
> Signed-off-by: Mingrui Ren <972931182@qq.com>
> ---
> drivers/tty/serial/imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You sent this twice? Which one is "correct"? I'll drop both from my
patch queue and wait for just one to be resent.
thanks,
greg k-h
parent reply other threads:[~2020-12-01 10:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <tencent_20B71295BC0C2FCB5807D81BC045ED802C06@qq.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8YWt5TGlcI93E8e@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=972931182@qq.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®