From: Greg KH <gregkh@linuxfoundation.org>
To: Clement Smith <rclemsmith@gmail.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] tty: serial: jsm: Fixed file by added more spacing in line 610
Date: Sat, 5 Dec 2020 17:30:01 +0100 [thread overview]
Message-ID: <X8u1iR6uajt2prf8@kroah.com> (raw)
In-Reply-To: <0c203c3dfd32ea016ed7c0de7a1e83a09eb91806.1607177807.git.rclemsmith@gmail.com>
On Sat, Dec 05, 2020 at 07:50:08PM +0530, Clement Smith wrote:
> Fixed a coding style issue
>
> Signed-off-by: Clement Smith <rclemsmith@gmail.com>
> ---
> drivers/tty/serial/jsm/jsm_tty.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The subject lines in this series is really funny.
Please don't do this. If you want to get practice in making coding
style cleanups, do it in drivers/staging/ which is why the code is
there. Don't "practice" in other parts of the kernel as it just gets in
the way of other development and review efforts.
good luck!
greg k-h
next prev parent reply other threads:[~2020-12-05 18:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1607177807.git.rclemsmith@gmail.com>
2020-12-05 14:20 ` Clement Smith
2020-12-05 16:30 ` Greg KH [this message]
2020-12-05 14:20 ` [PATCH 2/8] tty: serial: jsm: Fixed file by added more spacing in line 611 Clement Smith
2020-12-05 14:20 ` [PATCH 3/8] tty: serial: jsm: Fixed file by added more spacing in line 612 Clement Smith
2020-12-05 14:20 ` [PATCH 4/8] tty: serial: jsm: Fixed file by added more spacing in line 613 Clement Smith
2020-12-05 14:20 ` [PATCH 5/8] tty: serial: jsm: Fixed file by added more spacing in line 614 Clement Smith
2020-12-05 14:20 ` [PATCH 6/8] tty: serial: jsm: Fixed file by added more spacing in line 615 Clement Smith
2020-12-05 14:20 ` [PATCH 7/8] tty: serial: jsm: Fixed file by added more spacing in line 616 Clement Smith
2020-12-05 14:20 ` [PATCH 8/8] tty: serial: jsm: Removed assignment in if statement Clement Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8u1iR6uajt2prf8@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rclemsmith@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®