From: Greg KH <gregkh@linuxfoundation.org>
To: samuel.thibault@ens-lyon.org
Cc: linux-kernel@vger.kernel.org, speakup@linux-speakup.org
Subject: Re: [patch 1/3] speakup: Add synth parameter to io functions
Date: Thu, 10 Dec 2020 16:23:11 +0100 [thread overview]
Message-ID: <X9I9Xwh+Q3tHXh88@kroah.com> (raw)
In-Reply-To: <20201209205838.531299374@ens-lyon.org>
On Wed, Dec 09, 2020 at 09:58:30PM +0100, samuel.thibault@ens-lyon.org wrote:
> This merely adds the missing synth parameter to all io functions.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
The build still breaks when this patch is applied:
CC [M] drivers/accessibility/speakup/spk_ttyio.o
In file included from drivers/accessibility/speakup/spk_ttyio.c:9:
drivers/accessibility/speakup/spk_ttyio.c: In function ‘spk_ttyio_in’:
drivers/accessibility/speakup/spk_priv.h:31:27: warning: passing argument 1 of ‘ttyio_in’ makes pointer from integer without a cast [-Wint-conversion]
31 | #define SPK_SYNTH_TIMEOUT 100000 /* in micro-seconds */
| ^~~~~~
| |
| int
drivers/accessibility/speakup/spk_ttyio.c:344:18: note: in expansion of macro ‘SPK_SYNTH_TIMEOUT’
344 | return ttyio_in(SPK_SYNTH_TIMEOUT);
| ^~~~~~~~~~~~~~~~~
drivers/accessibility/speakup/spk_ttyio.c:315:49: note: expected ‘struct spk_synth *’ but argument is of type ‘int’
315 | static unsigned char ttyio_in(struct spk_synth *in_synth, int timeout)
| ~~~~~~~~~~~~~~~~~~^~~~~~~~
drivers/accessibility/speakup/spk_ttyio.c:344:9: error: too few arguments to function ‘ttyio_in’
344 | return ttyio_in(SPK_SYNTH_TIMEOUT);
| ^~~~~~~~
drivers/accessibility/speakup/spk_ttyio.c:315:22: note: declared here
315 | static unsigned char ttyio_in(struct spk_synth *in_synth, int timeout)
| ^~~~~~~~
drivers/accessibility/speakup/spk_ttyio.c: In function ‘spk_ttyio_in_nowait’:
drivers/accessibility/speakup/spk_ttyio.c:349:10: error: too few arguments to function ‘ttyio_in’
349 | u8 rv = ttyio_in(0);
| ^~~~~~~~
drivers/accessibility/speakup/spk_ttyio.c:315:22: note: declared here
315 | static unsigned char ttyio_in(struct spk_synth *in_synth, int timeout)
| ^~~~~~~~
drivers/accessibility/speakup/spk_ttyio.c: In function ‘spk_ttyio_in’:
drivers/accessibility/speakup/spk_ttyio.c:345:1: error: control reaches end of non-void function [-Werror=return-type]
345 | }
| ^
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:279: drivers/accessibility/speakup/spk_ttyio.o] Error 1
make[2]: *** [scripts/Makefile.build:496: drivers/accessibility/speakup] Error 2
make[1]: *** [scripts/Makefile.build:496: drivers/accessibility] Error 2
make: *** [Makefile:1805: drivers] Error 2
You can't break the build on any patches in a series :(
thanks,
greg k-h
next prev parent reply other threads:[~2020-12-10 15:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 20:58 [patch 0/3] speakup: simplify relation between line disc and synth samuel.thibault
2020-12-09 20:58 ` [patch 1/3] speakup: Add synth parameter to io functions samuel.thibault
2020-12-10 15:23 ` Greg KH [this message]
2020-12-10 15:24 ` Samuel Thibault
2020-12-10 20:03 ` Samuel Thibault
2021-01-05 13:39 ` Greg KH
2021-01-05 13:39 ` Samuel Thibault
2020-12-09 20:58 ` [patch 2/3] speakup: Reference synth from tty and tty from synth samuel.thibault
2020-12-09 20:58 ` [patch 3/3] speakup: Simplify spk_ttyio_out error handling samuel.thibault
-- strict thread matches above, loose matches on Subject: below --
2020-12-10 20:01 [patch 0/3] speakup: simplify relation between line disc and synth samuel.thibault
2020-12-10 20:01 ` [patch 1/3] speakup: Add synth parameter to io functions samuel.thibault
2020-11-30 22:25 [patch 0/3] speakup: simplify relation between line disc and synth Samuel Thibault
2020-11-30 22:26 ` [patch 1/3] speakup: Add synth parameter to io functions Samuel Thibault
2020-12-09 14:40 ` Greg KH
2020-12-09 21:14 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9I9Xwh+Q3tHXh88@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®