From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC561C2BBCA for ; Wed, 16 Dec 2020 14:31:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92C03233F6 for ; Wed, 16 Dec 2020 14:31:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726522AbgLPObY (ORCPT ); Wed, 16 Dec 2020 09:31:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726398AbgLPObY (ORCPT ); Wed, 16 Dec 2020 09:31:24 -0500 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C18CBC06179C for ; Wed, 16 Dec 2020 06:30:43 -0800 (PST) Received: by mail-qk1-x72d.google.com with SMTP id 143so22612860qke.10 for ; Wed, 16 Dec 2020 06:30:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qaDzrcpcSTwZW8tytURJAh2eSg1jyIVH/9nK8nDNqDU=; b=T1Zr3h4Iq8vWNDTKlJ1EtZlPyKSWSN1243m1QoE2SGB8sg+qzV33NbCQtLAZxopB43 sfnWoH9nTXqCNcvUePaAWpRk5J86we3mhnhdijN241xCgx/7Cfktp9tCUc/Cg4rvJHXM 92fH6UHEmMoklxfddTUFqsV+ctn0+hsYxulAzUHxkWao3o7323vDV6XEah1BYTgd2eG7 jZCE6Wfof2hKquiy8fF9FsPfA+EcjOui+ijmJI+p10LTVUgO4WfWe5nYA3X+9TzVbG2R otKkBWk587AZ9gQKnH2vkB2LjWInVoXwWCOhCUJpFezjiJxyBPGvmg90yjdqMwZvF3UZ nvGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=qaDzrcpcSTwZW8tytURJAh2eSg1jyIVH/9nK8nDNqDU=; b=sVbBAVbFVYbYw8zS8TJbQhTg5ejkeIDoPHQE0PTdNL3Rx9XSuWVJJvn99QMUXdD+Mf sRn+gb0Xq1CB7KbTBEY5thYzBcy+PLNdi+fCaTmWGMBfXTnxjGRv2qt8GTklCbviUyUs R+QuXnc5ThUV6rHiL9oP4H+AzHnoNGf8NYN20Cbuv6wRvRQUuWLdBui+8Y14mcyB1zOF 8vM9gxFkhBJbbWaukPTX3iCxXp52I4lvYFGB+VCyU+sIge4356Z2TVxNUYfhsJGsMUK6 jN15ePK3GKNRQYnRCVtHVXpj7exY5KCCbYU3qofsad7ry0u3NlF3Osft4dfu7qIsxau3 rQjw== X-Gm-Message-State: AOAM531hJQiQeKqVJdX8FJ1yq7+c5m+SfT/jH0odh5uV8xR7Tr4NM2yy hWoi3NOKwRU+/PAm1whVMqU= X-Google-Smtp-Source: ABdhPJyjomTrQaZA4W3xx1tHyVM+QiK01PdVqgXYvj+haKVRT0Un8g4HYWbMPsFpZjGiml6cdsjAYQ== X-Received: by 2002:a37:d205:: with SMTP id f5mr21462025qkj.248.1608129042744; Wed, 16 Dec 2020 06:30:42 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:cbde]) by smtp.gmail.com with ESMTPSA id o5sm1035306qti.47.2020.12.16.06.30.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Dec 2020 06:30:41 -0800 (PST) Sender: Tejun Heo Date: Wed, 16 Dec 2020 09:30:07 -0500 From: Tejun Heo To: Lai Jiangshan Cc: linux-kernel@vger.kernel.org, Lai Jiangshan , Hillf Danton , Valentin Schneider , Qian Cai , Peter Zijlstra , Vincent Donnefort Subject: Re: [PATCH 00/10] workqueue: break affinity initiatively Message-ID: References: <20201214155457.3430-1-jiangshanlai@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201214155457.3430-1-jiangshanlai@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 14, 2020 at 11:54:47PM +0800, Lai Jiangshan wrote: > From: Lai Jiangshan > > 06249738a41a ("workqueue: Manually break affinity on hotplug") > said that scheduler will not force break affinity for us. > > But workqueue highly depends on the old behavior. Many parts of the codes > relies on it, 06249738a41a ("workqueue: Manually break affinity on hotplug") > is not enough to change it, and the commit has flaws in itself too. > > We need to thoroughly update the way workqueue handles affinity > in cpu hot[un]plug, what is this patchset intends to do and > replace the Valentin Schneider's patch [1]. > > Patch 1 fixes a flaw reported by Hillf Danton . > I have to include this fix because later patches depends on it. > > The patchset is based on tip/master rather than workqueue tree, > because the patchset is a complement for 06249738a41a ("workqueue: > Manually break affinity on hotplug") which is only in tip/master by now. > > [1]: https://lore.kernel.org/r/ff62e3ee994efb3620177bf7b19fab16f4866845.camel@redhat.com Generally looks good to me. Please feel free to add Acked-by: Tejun Heo and route the series through tip. Thanks. -- tejun