mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Scott <jws22@cam.ac.uk>
To: linux-kernel@vger.kernel.org
Cc: James Scott <jws22@cam.ac.uk>
Subject: Bug warning in skbuff.c
Date: Tue, 16 Oct 2001 12:45:47 +0100 (BST)	[thread overview]
Message-ID: <XFMail.011016124547.jws22@cam.ac.uk> (raw)

Hi all.

(n.b. linux-2.4.10)

I am working on a new type of network at Cambridge University, and am writing a
linux kernel driver for the NIC we've built.  I get the following in
/var/log/messages once per packet:

Oct 16 12:27:42 cerealkiller kernel: Warning: kfree_skb on hard IRQ c300c6d0

because I am calling dev_kfree_skb from a hard IRQ for every outgoing packet
(the TX-complete interrupt).

I know that I can (and perhaps should) do as much as possible in a bottom half
tasklet, however right now this is all experimental and "inconsiderate" code.

What I want to know is - is the use of kfree_skb on a hard IRQ actually that
evil?  Is the "bug" just to remind me to be considerate, or is it to point out
real problems that might occur (e.g. in OOM cases?)

Thanks,
James

PS Please mail me explicitly (Im not on linux-kernel).  Thanks for your help.

                 reply	other threads:[~2001-10-16 11:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=XFMail.011016124547.jws22@cam.ac.uk \
    --to=jws22@cam.ac.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®