From: James Morris <jmorris@namei.org>
To: David Chinner <dgc@sgi.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
linux-security-module@vger.kernel.org,
Eric Paris <eparis@redhat.com>,
dhowells@redhat.com
Subject: Re: [patch, rfc] mm.h, security.h, key.h and preventing namespace poisoning
Date: Thu, 20 Dec 2007 15:11:40 +1100 (EST) [thread overview]
Message-ID: <Xine.LNX.4.64.0712201506520.6851@us.intercode.com.au> (raw)
In-Reply-To: <20071220014413.GK4612@sgi.com>
On Thu, 20 Dec 2007, David Chinner wrote:
> > I'm not sure I understand your namespace pollution issue, either.
>
> doing this globally:
>
> #ifdef CONFIG_SOMETHING
> extern int some_common_name(int a, int b, int c);
> #else
> #define some_common_name(a,b,c) 0
> #endif
I suspect it may be useful ensure all global identifiers for the key
subsystem are prefixed with key_, as 'copy_keys' does seem a little
generic.
> > +#ifdef CONFIG_SECURITY
> > +extern unsigned long mmap_min_addr;
> > +#endif
> > +
> > #include <asm/page.h>
> > #include <asm/pgtable.h>
> > #include <asm/processor.h>
>
> Fine by me.
I'll queue it for -mm & 2.6.25.
- James
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2007-12-20 4:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 9:38 David Chinner
2007-12-19 10:15 ` Alexey Dobriyan
2007-12-20 0:07 ` James Morris
2007-12-20 1:44 ` David Chinner
2007-12-20 4:11 ` James Morris [this message]
2007-12-25 22:05 ` Andrew Morton
2007-12-26 4:15 ` James Morris
2008-01-02 15:41 ` David Howells
2007-12-20 18:08 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Xine.LNX.4.64.0712201506520.6851@us.intercode.com.au \
--to=jmorris@namei.org \
--cc=dgc@sgi.com \
--cc=dhowells@redhat.com \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome