From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: "Joerg Roedel (AMD)" <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Chen-Yu Tsai <wens@kernel.org>,
Samuel Holland <samuel@sholland.org>,
Maxime Ripard <mripard@kernel.org>,
aiyengar1990@gmail.com
Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] iommu/sun50i: Don't report TLB prefetch walks as page faults
Date: Tue, 10 Nov 2026 17:04:46 +0100 [thread overview]
Message-ID: <XuGVSzNrS7KQLWfGI0rB-w@gmail.com> (raw)
In-Reply-To: <20261110-sun50i-iommu-prefetch-v1-0-43428e792ef6@gmail.com>
Dne torek, 10. november 2026 ob 07:05:16 Srednjeevropski standardni čas je Arun Iyengar via B4 Relay napisal(a):
> On an H616 with a display scanning out, the IOMMU reports page faults
> with master -1 at the IOVA right after the end of the framebuffer: once
> at the first fbcon frame, and then once per frame for a while after
> each TLB flush, e.g. while a video decoder frees its buffers. They are
> failed walks of the TLB prefetcher, which the hardware flags with bit 31
> of the page table interrupt registers and no master bit. Patch 1 stops
> reporting them. Patch 2 makes the remaining fault messages say which
> walk failed and what the interrupt register held.
>
> Tested on an Orange Pi Zero2 (H616) with HDMI forced on at 1024x768 and
> three 4K H.264 decodes through cedrus, on 7.3 kernels with and without
> the patches:
> - without: 214 "Page fault ... (master -1, dir rd)" lines;
> - with: none, no "Page fault" line at all, and no decode errors or
> timeouts.
> Since the patched kernel prints every fault that is not a masterless
> prefetch walk, this also shows that the hardware sets bit 31 for these
> walks.
First off, display engine isn't in merged yet. Second, I don't observe any
such issues with my wip H616 code.
I think it's best to wait until driver is merged and can be retested and
merged then, if needed.
Best regards,
Jernej
>
> These patches were developed with Claude (Anthropic) as a coding
> assistant. It investigated the problem and wrote the code and the commit
> messages; I reviewed them, and they were tested on an Orange Pi Zero2
> (H616) as described above.
>
> ---
> Arun Iyengar (2):
> iommu/sun50i: Don't report TLB prefetches of unmapped pages as faults
> iommu/sun50i: Print the page table level and status of a fault
>
> drivers/iommu/sun50i-iommu.c | 50 ++++++++++++++++++++++++++++++++++----------
> 1 file changed, 39 insertions(+), 11 deletions(-)
> ---
> base-commit: 2cf4be57b301ed2d7af82e70cff5dfd96894d8de
> change-id: 20261110-sun50i-iommu-prefetch-85cc9ecff559
>
> Best regards,
> --
> Arun Iyengar <aiyengar1990@gmail.com>
>
>
>
prev parent reply other threads:[~2026-11-10 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 6:05 Arun Iyengar via B4 Relay
2026-11-10 6:05 ` [PATCH 1/2] iommu/sun50i: Don't report TLB prefetches of unmapped pages as faults Arun Iyengar via B4 Relay
2026-11-10 6:05 ` [PATCH 2/2] iommu/sun50i: Print the page table level and status of a fault Arun Iyengar via B4 Relay
2026-11-10 16:04 ` Jernej Škrabec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=XuGVSzNrS7KQLWfGI0rB-w@gmail.com \
--to=jernej.skrabec@gmail.com \
--cc=aiyengar1990@gmail.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=robin.murphy@arm.com \
--cc=samuel@sholland.org \
--cc=wens@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®