From: Leo Yan <leo.yan@linaro.org>
To: James Clark <james.clark@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 13/14] perf kvm: Add TUI mode for stat report
Date: Tue, 28 Feb 2023 19:35:57 +0800 [thread overview]
Message-ID: <Y/3nHZdMQEoadoLG@leoy-yangtze.lan> (raw)
In-Reply-To: <678c5939-f512-d4f8-e290-9c0f2bf05023@arm.com>
Hi James,
On Tue, Feb 28, 2023 at 11:12:17AM +0000, James Clark wrote:
[...]
> > +static void print_result(struct perf_kvm_stat *kvm);
> > +
> > +#ifdef HAVE_SLANG_SUPPORT
>
> Hi Leo,
>
> I get an error because of this addition when building on x86. I think
> it's because I don't have HAVE_SLANG_SUPPORT. It might be the same error
> that you mentioned on v1?
>
> builtin-kvm.c:535:13: error: ‘print_result’ used but never defined
> [-Werror]
> 535 | static void print_result(struct perf_kvm_stat *kvm);
It's a bit weird for reporting this issue, since you could see I have
moved the function definition for print_result() ahead the macro
condition '#ifdef HAVE_SLANG_SUPPORT'.
But I found building failure with below command:
$ make VF=1 DEBUG=1 NO_SLANG=1
Let me repin this patch for the building failures; sorry I have been
negligent.
> Other than that, for the whole set:
>
> Reviewed-by: James Clark <james.clark@arm.com>
Thanks a lot for reviewing! I will apply your tag in next spin
except patch 13.
Leo
next prev parent reply other threads:[~2023-02-28 11:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 8:41 [PATCH v2 00/14] perf kvm: Support histograms and TUI mode Leo Yan
2023-02-28 8:41 ` [PATCH v2 01/14] perf kvm: Refactor overall statistics Leo Yan
2023-02-28 8:41 ` [PATCH v2 02/14] perf kvm: Add pointer to 'perf_kvm_stat' in kvm event Leo Yan
2023-02-28 8:41 ` [PATCH v2 03/14] perf kvm: Move up metrics helpers Leo Yan
2023-02-28 8:41 ` [PATCH v2 04/14] perf kvm: Use subtraction for comparison metrics Leo Yan
2023-02-28 8:41 ` [PATCH v2 05/14] perf kvm: Introduce histograms data structures Leo Yan
2023-02-28 8:41 ` [PATCH v2 06/14] perf kvm: Pass argument 'sample' to kvm_alloc_init_event() Leo Yan
2023-02-28 8:41 ` [PATCH v2 07/14] perf kvm: Parse address location for samples Leo Yan
2023-02-28 8:41 ` [PATCH v2 08/14] perf kvm: Add dimensions for KVM event statistics Leo Yan
2023-02-28 8:41 ` [PATCH v2 09/14] perf kvm: Use histograms list to replace cached list Leo Yan
2023-02-28 8:41 ` [PATCH v2 10/14] perf kvm: Polish sorting key Leo Yan
2023-02-28 8:41 ` [PATCH v2 11/14] perf kvm: Support printing attributions for dimensions Leo Yan
2023-02-28 8:41 ` [PATCH v2 12/14] perf kvm: Add dimensions for percentages Leo Yan
2023-02-28 8:41 ` [PATCH v2 13/14] perf kvm: Add TUI mode for stat report Leo Yan
2023-02-28 11:12 ` James Clark
2023-02-28 11:35 ` Leo Yan [this message]
2023-02-28 8:41 ` [PATCH v2 14/14] perf kvm: Update documentation to reflect new changes Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/3nHZdMQEoadoLG@leoy-yangtze.lan \
--to=leo.yan@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®