From: Mark Brown <broonie@kernel.org>
To: William Breathitt Gray <william.gray@linaro.org>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
michael@walle.cc, quarium@gmail.com, jhentges@accesio.com,
jay.dolan@accesio.com
Subject: Re: [PATCH 0/3] Migrate PCIe-IDIO-24 GPIO driver to the regmap API
Date: Tue, 28 Feb 2023 19:28:45 +0000 [thread overview]
Message-ID: <Y/5V7a4M+LhZQhsM@sirena.org.uk> (raw)
In-Reply-To: <Y/1ksJHUENCwg/jy@fedora>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On Mon, Feb 27, 2023 at 09:19:28PM -0500, William Breathitt Gray wrote:
> On Tue, Feb 28, 2023 at 07:09:50PM +0000, Mark Brown wrote:
> > The values from the config buffer are supposed to be written out in
> > regmap_irq_sync_unlock() - why is something custom needed here?
> The PCIe-IDIO-24 "COS Enable" serves a dual purpose of interrupt
> enabling/disabling as well as configuring the interrupt types. Since
> this register is used for masking, config buffer would clobber the
> register if we use it in this particular case. Instead, we ignore the
> config buffer and configure the type directly for the device (handling
> the case where interrupts are masked and shouldn't be enabled).
Could you be more concrete about what's going on here please? In what
way does this "COS Enable" serve these dual functions and why do they
clobber each other?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-02-28 19:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 1:53 William Breathitt Gray
2023-02-28 1:53 ` [PATCH 1/3] regmap: Pass regmap and irq_drv_data as parameters for set_type_config() William Breathitt Gray
2023-02-28 1:53 ` [PATCH 2/3] gpio: gpio-regmap: Expose struct gpio_regmap in linux/gpio/regmap.h William Breathitt Gray
2023-02-28 20:44 ` Michael Walle
2023-02-28 3:12 ` William Breathitt Gray
2023-02-28 1:53 ` [PATCH 3/3] gpio: pcie-idio-24: Migrate to the regmap API William Breathitt Gray
2023-03-01 4:11 ` kernel test robot
2023-02-28 19:09 ` [PATCH 0/3] Migrate PCIe-IDIO-24 GPIO driver " Mark Brown
2023-02-28 2:19 ` William Breathitt Gray
2023-02-28 19:28 ` Mark Brown [this message]
2023-02-28 2:40 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/5V7a4M+LhZQhsM@sirena.org.uk \
--to=broonie@kernel.org \
--cc=brgl@bgdev.pl \
--cc=jay.dolan@accesio.com \
--cc=jhentges@accesio.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=quarium@gmail.com \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®