From: Peter Zijlstra <peterz@infradead.org>
To: Deepak R Varma <drv@mailo.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Saurabh Singh Sengar <ssengar@microsoft.com>,
Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH] perf/x86/amd/core: Use sysfs_emit() in show() callback function
Date: Mon, 20 Feb 2023 12:37:13 +0100 [thread overview]
Message-ID: <Y/NbadiYAF5exJN0@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <Y++ukV1djYTd01vy@ubun2204.myguest.virtualbox.org>
On Fri, Feb 17, 2023 at 10:12:57PM +0530, Deepak R Varma wrote:
> Using sprintf/snprintf functions are error prone and suggested to be
> replaced by scnprintf/vscnrptintf as outlined in this [1] LWN article.
>
> A more recent recommendation is to use sysfs_emit() or sysfs_emit_at()
> as per Documentation/filesystems/sysfs.rst in show() callback function
> when formatting values to be returned to user-space. These helper
> functions are PAGE_SIZE aware and wrap a safer call to vscnprintf().
>
> [1] https://lwn.net/Articles/69419/
>
> Issue identified using the coccinelle device_attr_show.cocci script.
This Changelog fails to inform me of what the actual problem is and why
the proposed solution is better.
As such I cannot form an opinion on the patch and must decline.
(Also, I'm not going to chase down random links on the interweb,
Changelogs should be self contained)
prev parent reply other threads:[~2023-02-20 11:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 16:42 Deepak R Varma
2023-02-20 11:37 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/NbadiYAF5exJN0@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=drv@mailo.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=kumarpraveen@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=ssengar@microsoft.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®