From: Sakari Ailus <sakari.ailus@iki.fi>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: shravan kumar <shravan.chippa@microchip.com>,
paul.j.murphy@intel.com, daniele.alessandrelli@intel.com,
mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Prakash Battu <Prakash.Battu@microchip.com>
Subject: Re: [PATCH v11 3/5] media: i2c: imx334: support lower bandwidth mode
Date: Wed, 22 Feb 2023 12:03:09 +0200 [thread overview]
Message-ID: <Y/XoXZJUKKGzGVVL@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <Y/XnWOomz2N9fCvc@wendy>
On Wed, Feb 22, 2023 at 09:58:48AM +0000, Conor Dooley wrote:
> On Wed, Feb 22, 2023 at 11:14:29AM +0200, Sakari Ailus wrote:
> > On Wed, Feb 08, 2023 at 10:39:13AM +0530, shravan kumar wrote:
> > > From: Shravan Chippa <shravan.chippa@microchip.com>
>
> > > @@ -666,11 +885,26 @@ static int imx334_init_pad_cfg(struct v4l2_subdev *sd,
> > > struct v4l2_subdev_format fmt = { 0 };
> > >
> > > fmt.which = sd_state ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_ACTIVE;
> > > - imx334_fill_pad_format(imx334, &supported_mode, &fmt);
> > > + imx334_fill_pad_format(imx334, &supported_modes[0], &fmt);
> >
> > Now that there are multiple modes supported, this would appear to get the
> > width, height as well as the other fields (apart from mbus code) from the
> > first mode.
>
> Is this statement supposed to be a request to change something, or just
> a throwaway comment? It's a little hard for me to understand your
> intention here, sorry.
Just pointing to what looks like a bug.
--
Sakari Ailus
next prev parent reply other threads:[~2023-02-22 10:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 5:09 [PATCH v11 0/5] " shravan kumar
2023-02-08 5:09 ` [PATCH v11 1/5] media: i2c: imx334: replace __v4l2_ctrl_s_ctrl to __v4l2_ctrl_modify_range shravan kumar
2023-02-08 5:09 ` [PATCH v11 2/5] media: i2c: imx334: add missing reset values for mode 3840x2160_regs[] shravan kumar
2023-02-08 5:09 ` [PATCH v11 3/5] media: i2c: imx334: support lower bandwidth mode shravan kumar
2023-02-22 9:14 ` Sakari Ailus
2023-02-22 9:58 ` Conor Dooley
2023-02-22 10:03 ` Sakari Ailus [this message]
2023-02-22 10:06 ` Sakari Ailus
2023-02-22 10:20 ` Shravan.Chippa
2023-02-22 11:32 ` Sakari Ailus
2023-02-24 10:02 ` Shravan.Chippa
2023-02-24 10:51 ` Sakari Ailus
2023-02-08 5:09 ` [PATCH v11 4/5] dt-bindings: media: i2c: imx334 add new link_freq shravan kumar
2023-02-08 8:08 ` Krzysztof Kozlowski
2023-02-08 5:09 ` [PATCH v11 5/5] media: i2c: imx334: update pixel and link frequency shravan kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/XoXZJUKKGzGVVL@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=Prakash.Battu@microchip.com \
--cc=conor.dooley@microchip.com \
--cc=daniele.alessandrelli@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.j.murphy@intel.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shravan.chippa@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®