From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB592C61DA4 for ; Wed, 22 Feb 2023 13:40:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229764AbjBVNkW (ORCPT ); Wed, 22 Feb 2023 08:40:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229907AbjBVNkU (ORCPT ); Wed, 22 Feb 2023 08:40:20 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A603327498 for ; Wed, 22 Feb 2023 05:40:19 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id l7-20020a05600c4f0700b003e79fa98ce1so3512351wmq.2 for ; Wed, 22 Feb 2023 05:40:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=B4zo8Nq8J0Yr+vfRIFFqz72ULSWXGLZTJiTYN3NpfUU=; b=kqzBFy+VvPElF9Pz21swhoW3pB7D0WavOwSXl6z1K257i8Ok+E8L0j3vF8MST3buWn rWEuRzTW6eHhYMVYa+ofmuHarHvkbZYgs7anXaqG3aCBBMw+3bEV9qM/59Tu0OV0+ATW rEIZoIXcIY6H/H+mhVw4QdSR/OmYPpw0LUNq0AXGH16UlcFKWIP9qym/RgHxrsBflcCG cxVm8BtVuhmzfHEKh3daFRNnY6j4gZFJiJWv46Wbt3JCRQn9LFO18/+28EtTbsmOVPB/ OtTbGRjzL0uFGWS3AsXwZXg3mTxjYyMc6nD38RZ+ojtdg0gjTLC/DmVD9Zjts+GhNRjL FuPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B4zo8Nq8J0Yr+vfRIFFqz72ULSWXGLZTJiTYN3NpfUU=; b=cb5vv7JIV3asCHbesYmNtKdOCFUcUFY/Scu8rd+OJXgdZD2wp+sTLjYbkPqzYjd9Lx h1d0Bk/bEZcgM0il6vmAMDv2gNXE2qG3hEW+wkZhg5mUr80He8IQ5S8QKt2iD2kV4nZe OVArtt8vpMHqwH6uJWRWpxypy9C6ZdaAAD9yl383PZN3+Ns+fHkqAtsHCBSZkUrm+yAV l97BbPOuhlj9TLwuhICF2JTvwakpDODVREDIvVS0kYLNbkKsEEKDiFp6XNHsMzK4O6MM jIOeL2cxU8psksHRy5tkdpWht2DDUjrV4b+Avsp+flowpK5EceyuFCx60mQRxAKz7/2z SiMg== X-Gm-Message-State: AO0yUKWlHbhmzkRNDFxuHVNT3I76jk1dHHYz6VvhJ4M7f/CDGqSjd76R adbJqafnhnQLR8B2Y0K5Mms= X-Google-Smtp-Source: AK7set9G4vCcIIJPHs5YbZbgy0rj7gwp3j1ecTnX8yq5P6gFQRfWLV3dtRTHDvlqk2/EB0XjSAz69g== X-Received: by 2002:a05:600c:4e41:b0:3e2:1a5e:b150 with SMTP id e1-20020a05600c4e4100b003e21a5eb150mr6902090wmq.2.1677073218093; Wed, 22 Feb 2023 05:40:18 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id m22-20020a7bce16000000b003e209b45f6bsm6116877wmc.29.2023.02.22.05.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 05:40:17 -0800 (PST) Date: Wed, 22 Feb 2023 16:40:07 +0300 From: Dan Carpenter To: Philipp Hortmann Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] staging: rtl8192e: Remove entry .nic_type from struct rtl819x_ops Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 21, 2023 at 09:53:43PM +0100, Philipp Hortmann wrote: > Remove unchanged entry .nic_type and replace it with constant NIC_8192E. > This increases readability of the code. > > Signed-off-by: Philipp Hortmann > --- > drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 - > drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 1 - > drivers/staging/rtl8192e/rtl8192e/rtl_pci.c | 6 +++--- > 3 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c > index 2d2f9d4a0ff5..044cab649ff1 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c > @@ -26,7 +26,6 @@ int hwwep = 1; > static char *ifname = "wlan%d"; > > static const struct rtl819x_ops rtl819xp_ops = { > - .nic_type = NIC_8192E, > }; Delete. > > static struct pci_device_id rtl8192_pci_id_tbl[] = { > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h > index fa72f8891409..f75cc96052d9 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h > @@ -204,7 +204,6 @@ struct rtl8192_tx_ring { > }; > > struct rtl819x_ops { > - enum nic_t nic_type; > }; Delete this empty struct too. Otherwise these patches are really nice. Thanks! regards, dan carpenter