From: Sean Christopherson <seanjc@google.com>
To: Jun Miao <jun.miao@intel.com>
Cc: pbonzini@redhat.com, corbet@lwn.net, maciej.szmigiero@oracle.com,
kvm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: Align the function name of kvm_swap_active_memslots()
Date: Wed, 22 Feb 2023 10:39:30 -0800 [thread overview]
Message-ID: <Y/ZhYiN+oYbx6z5n@google.com> (raw)
In-Reply-To: <20230220084500.938739-1-jun.miao@intel.com>
Nit, "Align" is a confusing because it's often used to refer to indentation. Maybe?
KVM: Fix comments that refer to the non-existent install_new_memslots()
On Mon, Feb 20, 2023, Jun Miao wrote:
> The function of install_new_memslots() is replaced by kvm_swap_active_memslots().
> In order to avoid confusion, align the name in the comments which always be ignored.
>
> Fixes: a54d806688fe "KVM: Keep memslots in tree-based structures instead of array-based ones")
> Signed-off-by: Jun Miao <jun.miao@intel.com>
> ---
> Documentation/virt/kvm/locking.rst | 2 +-
> include/linux/kvm_host.h | 4 ++--
> virt/kvm/kvm_main.c | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/virt/kvm/locking.rst b/Documentation/virt/kvm/locking.rst
> index 14c4e9fa501d..ac0e549a3ae7 100644
> --- a/Documentation/virt/kvm/locking.rst
> +++ b/Documentation/virt/kvm/locking.rst
> @@ -21,7 +21,7 @@ The acquisition orders for mutexes are as follows:
> - kvm->mn_active_invalidate_count ensures that pairs of
> invalidate_range_start() and invalidate_range_end() callbacks
> use the same memslots array. kvm->slots_lock and kvm->slots_arch_lock
> - are taken on the waiting side in install_new_memslots, so MMU notifiers
> + are taken on the waiting side in kvm_swap_active_memslots, so MMU notifiers
Can you send a v2 and opportunistically add () to the blurbs that don't have it?
I.e. so these are all "kvm_swap_active_memslots()"?
Thanks!
next prev parent reply other threads:[~2023-02-22 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 8:45 Jun Miao
2023-02-22 18:39 ` Sean Christopherson [this message]
2023-02-23 5:07 ` Miao, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/ZhYiN+oYbx6z5n@google.com \
--to=seanjc@google.com \
--cc=corbet@lwn.net \
--cc=jun.miao@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.szmigiero@oracle.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®