From: Tejun Heo <tj@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, bpf <bpf@vger.kernel.org>,
Dave Marchevsky <davemarchevsky@meta.com>,
David Vernet <void@manifault.com>,
LKML <linux-kernel@vger.kernel.org>,
Kernel Team <kernel-team@meta.com>
Subject: Re: [PATCH bpf-next] bpf: Add bpf_cgroup_from_id() kfunc
Date: Wed, 22 Feb 2023 15:22:53 -1000 [thread overview]
Message-ID: <Y/a/7ftfWVYpDTO0@slm.duckdns.org> (raw)
In-Reply-To: <CAADnVQL0Zf3Dq=6wCMmj+R9bz1B1J4b=mUkvkObKfPQprUjyag@mail.gmail.com>
On Wed, Feb 22, 2023 at 01:20:19PM -0800, Alexei Starovoitov wrote:
> On Tue, Feb 21, 2023 at 2:09 PM Tejun Heo <tj@kernel.org> wrote:
> >
> > cgroup ID is an userspace-visible 64bit value uniquely identifying a given
> > cgroup. As the IDs are used widely, it's useful to be able to look up the
> > matching cgroups. Add bpf_cgroup_from_id().
> >
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> > ---
> > Documentation/bpf/kfuncs.rst | 10 +++--
> > kernel/bpf/helpers.c | 18 ++++++++
> > .../selftests/bpf/prog_tests/cgrp_kfunc.c | 1 +
> > .../selftests/bpf/progs/cgrp_kfunc_common.h | 1 +
> > .../selftests/bpf/progs/cgrp_kfunc_success.c | 42 +++++++++++++++++++
> > 5 files changed, 69 insertions(+), 3 deletions(-)
>
> Looks great, but could you please split it into two patches:
> One for helpers.c and kfuncs.rst and another for selftests
> with [PATCH bpf-next] selftests/bpf: subject ?
> Doesn't matter much in this case, but it might ease backporting
> and easier to track patches grouped by subj.
Will do.
Thanks.
--
tejun
prev parent reply other threads:[~2023-02-23 1:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 22:08 Tejun Heo
2023-02-22 21:20 ` Alexei Starovoitov
2023-02-23 1:22 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/a/7ftfWVYpDTO0@slm.duckdns.org \
--to=tj@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davemarchevsky@meta.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@meta.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=void@manifault.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®