mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: KP Singh <kpsingh@kernel.org>
Cc: linux-kernel@vger.kernel.org, pjt@google.com, evn@google.com,
	jpoimboe@kernel.org, tglx@linutronix.de, x86@kernel.org,
	hpa@zytor.com, peterz@infradead.org,
	pawan.kumar.gupta@linux.intel.com, kim.phillips@amd.com,
	alexandre.chartre@oracle.com, daniel.sneddon@linux.intel.com,
	corbet@lwn.net, bp@suse.de, linyujun809@huawei.com,
	jmattson@google.com, "José Oliveira" <joseloliveira11@gmail.com>,
	"Rodrigo Branco" <rodrigo@kernelhacking.com>,
	"Alexandra Sandulescu" <aesa@google.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] x86/speculation: Allow enabling STIBP with legacy IBRS
Date: Thu, 23 Feb 2023 13:44:58 +0100	[thread overview]
Message-ID: <Y/dfyh1U/qDR1Ymw@zn.tnic> (raw)
In-Reply-To: <CACYkzJ4WigzaOCR4V9=e60ka=NNncWRB-j78DLRuzdSOZXvwrA@mail.gmail.com>

On Wed, Feb 22, 2023 at 11:41:59AM -0800, KP Singh wrote:
> Sure, I think the docs do already cover it,

I mean *our docs*. The stuff you're adding in your patch 2.

> but I sort of disagree with your statement around the commit message.
> I feel the more context you can add in the commit message, the better
> it is.

That's ofc wrong. And you'll find that out when you do git archeology
and you come across a huuuge wall of text explaining the world and some
more.

No, commit messages should be to the point with a structure similar to
something like this:

1. Prepare the context for the explanation briefly.

2. Explain the problem at hand.

3. "It happens because of <...>"

4. "Fix it by doing X"

5. "(Potentially do Y)."

concentrating on *why* the fix is being done.

> When I am looking at the change log, it would be helpful to have the
> information that I mentioned in the Q&A. Small things like, "eIBRS
> needs the IBRS bit set which also enables cross-thread protections" is
> a very important context for this patch IMHO. Without this one is just
> left head scratching and scrambling to read lengthy docs and processor
> manuals.

Yes, that's why you say in the commit message: "For more details, see
Documentation/admin-guide/hw-vuln/spectre.rst." where:

1. you can explain in a lot more detail

2. put it in place where people can find it *easily*

> This sort of loosely implies that the IBRS bit also enables
> cross-thread protections. Can you atleast add this one explicitly?
> 
> "Setting the IBRS bit also enables cross thread protections"

Ok.

> Not at the stage when the kernel decides to drop the STIBP protection
> when eIBRS is enabled.

We can't dump every possible interaction between the mitigations. It is
a huge mess already. But I'm open to looking at improvements of the
situation *and* documenting stuff as we go.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2023-02-23 12:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 18:49 KP Singh
2023-02-21 18:49 ` [PATCH v2 2/2] Documentation/hw-vuln: Document the interaction between IBRS and STIBP KP Singh
2023-02-23 14:52   ` Borislav Petkov
2023-02-24  3:30     ` KP Singh
2023-02-26  1:42     ` KP Singh
2023-02-21 19:29 ` [PATCH v2 1/2] x86/speculation: Allow enabling STIBP with legacy IBRS Greg KH
2023-02-21 19:29 ` Greg KH
2023-02-21 19:35   ` KP Singh
2023-02-21 19:47     ` Greg KH
2023-02-21 19:57       ` Borislav Petkov
2023-02-21 20:09         ` Greg KH
2023-02-21 20:23           ` Borislav Petkov
2023-02-22  3:07 ` Pawan Gupta
2023-02-22  5:49   ` KP Singh
2023-02-22  8:25     ` Pawan Gupta
2023-02-22 12:32     ` Borislav Petkov
2023-02-22 13:56       ` David Laight
2023-02-22 12:24 ` Borislav Petkov
2023-02-22 17:16   ` KP Singh
2023-02-22 17:48     ` Borislav Petkov
2023-02-22 19:41       ` KP Singh
2023-02-23 12:44         ` Borislav Petkov [this message]
2023-02-26  1:50           ` KP Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y/dfyh1U/qDR1Ymw@zn.tnic \
    --to=bp@alien8.de \
    --cc=aesa@google.com \
    --cc=alexandre.chartre@oracle.com \
    --cc=bp@suse.de \
    --cc=corbet@lwn.net \
    --cc=daniel.sneddon@linux.intel.com \
    --cc=evn@google.com \
    --cc=hpa@zytor.com \
    --cc=jmattson@google.com \
    --cc=joseloliveira11@gmail.com \
    --cc=jpoimboe@kernel.org \
    --cc=kim.phillips@amd.com \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linyujun809@huawei.com \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=rodrigo@kernelhacking.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®