mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, johan+linaro@kernel.org,
	Marc Zyngier <maz@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] irqdomain: fix regression for Xen guests
Date: Fri, 24 Feb 2023 12:24:45 +0100	[thread overview]
Message-ID: <Y/iefavPQ95lkzDe@hovoldconsulting.com> (raw)
In-Reply-To: <20230223083800.31347-1-jgross@suse.com>

On Thu, Feb 23, 2023 at 09:38:00AM +0100, Juergen Gross wrote:
> The recent switch to per-domain locking caused a NULL dereference in
> irq_domain_create_hierarchy(), as Xen code is calling
> msi_create_irq_domain() with a NULL parent pointer.

This was unexpected. Apparently the Intel VMD driver also does this (see
vmd_enable_domain()).

> Fix that by testing parent to be set before dereferencing it. For a
> non-existing parent the irq-domain's root will stay to point to
> itself.

An alternative could be to have msi_create_irq_domain() handle the
no-parent case explicitly, but this looks the right fix for now (e.g. as
irq_domain_create_tree() does not take a flag parameter).

> Fixes: 9dbb8e3452ab ("irqdomain: Switch to per-domain locking")
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  kernel/irq/irqdomain.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index aa5b7eeeceb8..6522dfb2e49c 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -1172,7 +1172,8 @@ struct irq_domain *irq_domain_create_hierarchy(struct irq_domain *parent,
>  		domain = __irq_domain_create(fwnode, 0, ~0, 0, ops, host_data);
>  
>  	if (domain) {
> -		domain->root = parent->root;
> +		if (parent)
> +			domain->root = parent->root;
>  		domain->parent = parent;
>  		domain->flags |= flags;

Reviewed-by: Johan Hovold <johan+linaro@kernel.org>

Johan

      parent reply	other threads:[~2023-02-24 11:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23  8:38 Juergen Gross
2023-02-23 14:59 ` [tip: irq/urgent] irqdomain: Add missing NULL pointer check in irq_domain_create_hierarchy() tip-bot2 for Juergen Gross
2023-02-24 11:24 ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y/iefavPQ95lkzDe@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=jgross@suse.com \
    --cc=johan+linaro@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®