From: Mark Brown <broonie@kernel.org>
To: Krishna Yarlagadda <kyarlagadda@nvidia.com>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH] spi: tegra210-quad: Fix iterator outside loop
Date: Fri, 24 Feb 2023 17:56:03 +0000 [thread overview]
Message-ID: <Y/j6MxmOkZj/TKej@sirena.org.uk> (raw)
In-Reply-To: <DM4PR12MB5769BDB91342A9768207BD84C3A89@DM4PR12MB5769.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
On Fri, Feb 24, 2023 at 04:50:00PM +0000, Krishna Yarlagadda wrote:
> > > msg->actual_length += xfer->len;
> > > + if (!xfer->cs_change && transfer_phase == DATA_TRANSFER)
> > {
> > > + tegra_qspi_transfer_end(spi);
> > > + spi_transfer_delay_exec(xfer);
> > > + }
> > > transfer_phase++;
> > > }
> > > - if (!xfer->cs_change) {
> > > - tegra_qspi_transfer_end(spi);
> > > - spi_transfer_delay_exec(xfer);
> > > - }
> > This looks like it'll do the wrong thing and do a change on every
> > transfer if cs_change isn't set?
> This condition is hit only in data phase which is end of message.
Shouldn't this just be moved into the DATA_TRANSFER case statement?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-02-24 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 16:35 Krishna Yarlagadda
2023-02-24 16:47 ` Mark Brown
2023-02-24 16:50 ` Krishna Yarlagadda
2023-02-24 17:56 ` Mark Brown [this message]
2023-02-27 10:36 ` Krishna Yarlagadda
2023-02-27 18:23 ` Mark Brown
2023-02-27 19:44 ` Krishna Yarlagadda
2023-02-28 19:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/j6MxmOkZj/TKej@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®