Re: [PATCH v2 2/2] pinctrl: add mt7981 pinctrl driver

[Daniel Golle <daniel@makrotopia.org>]

On Thu, Feb 16, 2023 at 07:32:13PM +0300, Arınç ÜNAL wrote:
> On 16.02.2023 19:26, Daniel Golle wrote:
> > On Thu, Feb 16, 2023 at 04:50:57PM +0300, Arınç ÜNAL wrote:
> > > Hi Daniel,
> > > 
> > > On 26.01.2023 03:34, Daniel Golle wrote:
> > > > Add pinctrl driver for the MediaTek MT7981 SoC, based on the driver
> > > > which can also be found the SDK.
> > > > 
> > > > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > > > ---
> > > >    drivers/pinctrl/mediatek/Kconfig          |    5 +
> > > >    drivers/pinctrl/mediatek/Makefile         |    1 +
> > > >    drivers/pinctrl/mediatek/pinctrl-mt7981.c | 1048 +++++++++++++++++++++
> > > >    3 files changed, 1054 insertions(+)
> > > >    create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt7981.c
> > > > 
> > > > diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
> > > > index fed02c6fea062..f20c28334bcbf 100644
> > > > --- a/drivers/pinctrl/mediatek/Kconfig
> > > > +++ b/drivers/pinctrl/mediatek/Kconfig
> > > > @@ -127,6 +127,11 @@ config PINCTRL_MT7622
> > > >    	default ARM64 && ARCH_MEDIATEK
> > > >    	select PINCTRL_MTK_MOORE
> > > > +config PINCTRL_MT7981
> > > > +	bool "Mediatek MT7981 pin control"
> > > > +	depends on OF
> > > > +	select PINCTRL_MTK_MOORE
> > > > +
> > > 
> > > Is there a reason why you removed these lines from v1?
> > 
> > Oh, that seemed to have happened by accident. Imho it'd be better
> > to have these two lines there as well.
> 
> Agreed. I'm preparing some patches to move the pinctrl driver for the
> MediaTek MIPS SoCs here, this driver appears on the menuconfig even though
> it shouldn't. Will you fix this yourself, or I can do it and add it to my
> upcoming patch series.

If you are anyway planning to send out a series of patches for pinctrl
please include a patch adding these two lines as well, I will Ack that
patch.