mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Lee Jones <lee@kernel.org>,
	linux-kernel@vger.kernel.org, linux@ew.tq-group.com
Subject: Re: [PATCH 1/3] mfd: tqmx86: do not access I2C_DETECT register through io_base
Date: Thu, 16 Feb 2023 18:19:34 +0100	[thread overview]
Message-ID: <Y+5lptaM0cnj+WBi@lunn.ch> (raw)
In-Reply-To: <59041b6d888c886edef5a97fc6e3319d235e101a.1676557968.git.matthias.schiffer@ew.tq-group.com>

> -	i2c_det = ioread8(io_base + TQMX86_REG_I2C_DETECT);
> +	i2c_det = inb(TQMX86_REG_I2C_DETECT);

I think it would be good to add a comment, since it now looks out of
place compared to all the other ioread8().

      Andrew

      parent reply	other threads:[~2023-02-16 17:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16 14:34 Matthias Schiffer
2023-02-16 14:34 ` [PATCH 2/3] mfd: tqmx86: specify IO port register range more precisely Matthias Schiffer
2023-02-16 17:20   ` Andrew Lunn
2023-02-16 14:34 ` [PATCH 3/3] mfd: tqmx86: correct board names for TQMxE39x Matthias Schiffer
2023-02-16 17:11   ` Andrew Lunn
2023-02-16 17:19 ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+5lptaM0cnj+WBi@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@ew.tq-group.com \
    --cc=matthias.schiffer@ew.tq-group.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®