From: Mark Brown <broonie@kernel.org>
To: Daniel Beer <daniel.beer@igorinstitute.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Andy Liu <andy-liu@ti.com>
Subject: Re: [PATCH v3 2/2] ASoC: tas5805m: add missing page switch.
Date: Mon, 6 Feb 2023 13:11:09 +0000 [thread overview]
Message-ID: <Y+D8bf/19aOL7Wzl@sirena.org.uk> (raw)
In-Reply-To: <1fea38a71ea6ab0225d19ab28d1fa12828d762d0.1675497326.git.daniel.beer@igorinstitute.com>
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
On Thu, Oct 27, 2022 at 09:38:38PM +1300, Daniel Beer wrote:
> In tas5805m_refresh, we switch pages to update the DSP volume control,
> but we need to switch back to page 0 before trying to alter the
> soft-mute control. This latter page-switch was missing.
You should just use the register windowing support in regmap, it will
take care of this for you, avoiding any further similar errors.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-02-06 13:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 7:55 [PATCH v3 0/2] Two bug fixes for tas5805m codec driver Daniel Beer
2022-10-27 8:28 ` [PATCH v3 1/2] ASoC: tas5805m: rework to avoid scheduling while atomic Daniel Beer
2022-10-27 8:38 ` [PATCH v3 2/2] ASoC: tas5805m: add missing page switch Daniel Beer
2023-02-06 13:11 ` Mark Brown [this message]
2023-02-06 20:45 ` Daniel Beer
2023-02-06 21:14 ` Mark Brown
2023-02-06 21:37 ` [PATCH v3 0/2] Two bug fixes for tas5805m codec driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+D8bf/19aOL7Wzl@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andy-liu@ti.com \
--cc=daniel.beer@igorinstitute.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®