From: Borislav Petkov <bp@alien8.de>
To: silviazhaooc <silviazhao-oc@zhaoxin.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, namhyung@kernel.org, tglx@linutronix.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
cobechen@zhaoxin.com, louisqi@zhaoxin.com,
silviazhao@zhaoxin.com, tonywwang@zhaoxin.com,
kevinbrace@gmx.com, 8vvbbqzo567a@nospam.xutrox.com
Subject: Re: [PATCH] x86/perf/zhaoxin: Add stepping check for ZX-C
Date: Mon, 6 Feb 2023 12:13:11 +0100 [thread overview]
Message-ID: <Y+Dgx7EeRufHdx17@zn.tnic> (raw)
In-Reply-To: <1d808c21-f54d-1506-d95a-0276430aea8d@zhaoxin.com>
Hi Silvia,
On Mon, Feb 06, 2023 at 06:55:21PM +0800, silviazhaooc wrote:
> Thanks for your reply.
You're welcome.
First of all, please do not top-post when replying on a public mailing
list but put your reply under the text you're replying to. Like the rest
of us do.
> As I mentioned before, Nano has several series. We cannot test if all of
> them have the bug.
If you cannot test if all of them have the bug, then testing the
stepping as you do is wrong too.
You need an unambiguous way to differentiate between ZXC and Nano CPUs.
If steppings >= 0xe belong solely to ZXC, then state that in a comment
above it so that you can exclude Nano.
If Nano starts using those steppings later, though, then that check will
become wrong too.
So I need a statement: "this is how you detect a ZXC CPU unambiguously"
and then use that method when enabling PMU support on it and *only* on
it.
Makes more sense?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-02-06 11:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 9:17 silviazhao-oc
2023-02-02 23:53 ` Kevin Brace
2023-02-03 3:12 ` silviazhaooc
2023-02-04 13:44 ` Borislav Petkov
2023-02-06 8:26 ` silviazhaooc
2023-02-06 9:48 ` Borislav Petkov
2023-02-06 10:55 ` silviazhaooc
2023-02-06 11:13 ` Borislav Petkov [this message]
2023-02-07 8:42 ` silviazhaooc
2023-02-07 18:30 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+Dgx7EeRufHdx17@zn.tnic \
--to=bp@alien8.de \
--cc=8vvbbqzo567a@nospam.xutrox.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=cobechen@zhaoxin.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=kevinbrace@gmx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=louisqi@zhaoxin.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=silviazhao-oc@zhaoxin.com \
--cc=silviazhao@zhaoxin.com \
--cc=tglx@linutronix.de \
--cc=tonywwang@zhaoxin.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®