From: Andreas Feldner <pelzi@flying-snail.de>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH] ARM: dts: allwinner: minimize irq debounce filter per default
Date: Mon, 6 Feb 2023 20:51:50 +0100 [thread overview]
Message-ID: <Y+FaVorMl37F5Dve@debian-qemu.internal.flying-snail.de> (raw)
The SoC features debounce logic for external interrupts. Per default,
this is based on a 32kHz oscillator, in effect filtering away multiple
interrupts separated by less than roughly 100µs.
This patch sets different defaults for this filter for this board:
PG is connected to non-mechanical components, without any risk for
showing bounces. PA is mostly exposed to GPIO pins, however the
existence of a debounce filter is undesirable as well if electronic
components are connected.
Additionally, the clock-frequency attribute is added for each of
the 4 cores to eliminate the kernel error message on boot, that
the attribute is missing.
Signed-off-by: Andreas Feldner <pelzi@flying-snail.de>
---
.../dts/sun8i-h2-plus-bananapi-m2-zero.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
index d729b7c705db..1fc0d5d1e51a 100644
--- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
+++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
@@ -113,6 +113,22 @@ wifi_pwrseq: wifi_pwrseq {
&cpu0 {
cpu-supply = <®_vdd_cpux>;
+ clock-frequency = <1296000000>;
+};
+
+&cpu1 {
+ cpu-supply = <®_vdd_cpux>;
+ clock-frequency = <1296000000>;
+};
+
+&cpu2 {
+ cpu-supply = <®_vdd_cpux>;
+ clock-frequency = <1296000000>;
+};
+
+&cpu3 {
+ cpu-supply = <®_vdd_cpux>;
+ clock-frequency = <1296000000>;
};
&de {
@@ -193,6 +209,8 @@ bluetooth {
};
&pio {
+ /* 1µs debounce filter on both IRQ banks */
+ input-debounce = <1 1>;
gpio-line-names =
/* PA */
"CON2-P13", "CON2-P11", "CON2-P22", "CON2-P15",
--
2.30.2
next reply other threads:[~2023-02-06 21:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 19:51 Andreas Feldner [this message]
2023-02-07 1:16 ` Andre Przywara
2023-02-08 12:50 ` Andreas Feldner
2023-02-09 20:29 ` Andre Przywara
2023-02-10 8:29 ` Maxime Ripard
2023-02-10 9:44 ` Andre Przywara
2023-02-10 10:06 ` Maxime Ripard
2023-02-10 10:18 ` Andre Przywara
2023-02-11 12:50 ` pelzi
2023-02-11 15:13 ` Andre Przywara
2023-02-11 18:08 ` [PATCH] pinctrl: sunxi: set minimal debounce on input-debounce 0 Andreas Feldner
2023-02-11 19:59 ` Andre Przywara
2023-02-13 8:43 ` [PATCH] ARM: dts: allwinner: minimize irq debounce filter per default Maxime Ripard
2023-02-13 8:49 ` pelzi
2023-02-13 9:18 ` Maxime Ripard
2023-02-13 11:56 ` Andre Przywara
2023-02-14 18:49 ` pelzi
2023-02-15 8:36 ` Maxime Ripard
2023-02-11 19:45 ` Samuel Holland
2023-02-13 1:51 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+FaVorMl37F5Dve@debian-qemu.internal.flying-snail.de \
--to=pelzi@flying-snail.de \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®