From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D84BC636D3 for ; Mon, 6 Feb 2023 21:14:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230197AbjBFVOn (ORCPT ); Mon, 6 Feb 2023 16:14:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229951AbjBFVOl (ORCPT ); Mon, 6 Feb 2023 16:14:41 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72AD47689 for ; Mon, 6 Feb 2023 13:14:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0F33861024 for ; Mon, 6 Feb 2023 21:14:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CC1FC433EF; Mon, 6 Feb 2023 21:14:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675718078; bh=riTB1YokzEFFDU4GzUfnUbRbAWC2sdyJCh34WVA0iyU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uOlR740qcEbFNWHQHLtvWGGe0sBxuYEHajtCVC4uTaWPl9L7gjr5Toz2/gJ1nlkrJ 08lZ39/Xu4Ca+NHu1hj1PflPTSodIkpRR3CYt/cpDvUgPWIM6Q+AZtHa2ptzPZG68M cu1p5vVZpGmHn0vdKrph9ALM9hMhYTAQ9In4FhzdDI7XgRsFr1n3J803akkOk14V9X C8voOKR36DMXk3kFL6rRQeuCKD7zfmOIeTwahOWNALnd2fkSej2onXJa7rns3fZFRA lUqmfwqBJtLewY78tYpzz1zE3a5JQnB/cgaeUTASknGOHJ2dgs+JNR+vraEgCcL0uU JNKoQCyCYexyg== Date: Mon, 6 Feb 2023 21:14:34 +0000 From: Mark Brown To: Daniel Beer Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Andy Liu Subject: Re: [PATCH v3 2/2] ASoC: tas5805m: add missing page switch. Message-ID: References: <1fea38a71ea6ab0225d19ab28d1fa12828d762d0.1675497326.git.daniel.beer@igorinstitute.com> <20230206204546.GA233871@nyquist.nev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dCj5T8jTG3AIPXcS" Content-Disposition: inline In-Reply-To: <20230206204546.GA233871@nyquist.nev> X-Cookie: Hope is a waking dream. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dCj5T8jTG3AIPXcS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 07, 2023 at 09:45:46AM +1300, Daniel Beer wrote: > We did discuss this a while back when the driver first went in. > Unfortunately the vendor software tools provide configuration for the > part in the form of a sequence of raw register writes, including > explicit page changes: > https://lore.kernel.org/lkml/Yd85bjKEX9JnoOlI@sirena.org.uk/ That seems surmountable, either bypassing regmap or parsing the configuration files. > Aside from this, I have two other practical issues. > The first is that I'm not sure how exactly to implement the paging > scheme in terms of regmap_range_cfg (assuming this is what you're > referring to). This chip has multi-level paging (books/pages), with the > book selection register itself requiring paging to access. A sequence of That's absolutely fine, this isn't the first device which has such a setup and the code handles nested windows fine. > Secondly, the patches as submitted here have been tested, but I don't > currently have access to hardware. I'm very hesitant to make a > significant change without retesting and leave the driver in a broken > state again. Presumably someone does given that the problem was noticed? --dCj5T8jTG3AIPXcS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPhbbkACgkQJNaLcl1U h9C9Ewf+KewXF5GyAN4ZUwICEK/KJH2L6ZUXWmLiuhWilIkEZaxZb9Dc3zW29GHv P1OSQba9GM+o+FyQX1lQaGp7lwt3POmUF4nVlxyDnuHZrSGJwbeS0ermaomFstJe 4n9PY1CpIsxAFyhXLaeOO5mFpYins/crft0TIgT03bLn5BaM5xu8bn9ywQYNHdpI 0u3Qy/k8KpO32qheL99/Xcb1twsZLEbLIRwpAaLAE+r0NXeCU9B4fnov/S33a9cF PnlMk9384GoGtwqUjUcWZ5cDMjNffDZNLFht97JlTzC8hbaDj84zfolZ4vlyQEYw QhRF7Id4KquZJZKzWuzWSoBYkm5ZBg== =0Hl7 -----END PGP SIGNATURE----- --dCj5T8jTG3AIPXcS--