From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77E00C05027 for ; Wed, 8 Feb 2023 12:31:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230335AbjBHMbZ (ORCPT ); Wed, 8 Feb 2023 07:31:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbjBHMbX (ORCPT ); Wed, 8 Feb 2023 07:31:23 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B064AAD2D for ; Wed, 8 Feb 2023 04:31:22 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4C67D616C1 for ; Wed, 8 Feb 2023 12:31:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26B51C433D2; Wed, 8 Feb 2023 12:31:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675859481; bh=Tb3++ufYdLByX152q1sqsAfFlS7LFPTgvHN6jET/kg4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M/KKNJjcQvcBwYAbTmZBT0TWHLxnnRpCL6Rw2sECaV1OaYpwT+Mn/t0DBkocCHiSF 7eKpQYoHt2a+2ClJy3XhJ/eY7MfnQHU0AM0nreOhsmi/cmRI/+uuSzAkxTQSitOLyl c72AWBYybuiYOz4gCPJQ329CP8o2/fvcPDlpqGTY= Date: Wed, 8 Feb 2023 13:31:18 +0100 From: Greg Kroah-Hartman To: Philipp Hortmann Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/10] staging: rtl8192e: Calculate definition of MSR_LINK_MASK Message-ID: References: <8c8a126a83683bae69d0fd20a93bdea8f810f6d0.1675792435.git.philipp.g.hortmann@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c8a126a83683bae69d0fd20a93bdea8f810f6d0.1675792435.git.philipp.g.hortmann@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 07, 2023 at 07:16:22PM +0100, Philipp Hortmann wrote: > Calculate definition of MSR_LINK_MASK ((1<<0)|(1<<1)) = 3. Equation is not > accepted by checkpatch because of missing spaces. > > Signed-off-by: Philipp Hortmann > --- > drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h > index 1546bb575293..20a35c9caee8 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h > @@ -170,7 +170,7 @@ enum _RTL8192PCI_HW { > #define BW_OPMODE_20MHZ BIT2 > IC_VERRSION = 0x301, > MSR = 0x303, > -#define MSR_LINK_MASK ((1<<0)|(1<<1)) > +#define MSR_LINK_MASK 3 This is a bit field, it should be: #define MSR_LINK_MASK (BIT(1) | BIT(0)) right? thanks, greg k-h