From: Luis Chamberlain <mcgrof@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org,
p.raghav@samsung.com, dave@stgolabs.net,
a.manzanares@samsung.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/2] shmem: set shmem_writepage() variables early
Date: Wed, 8 Feb 2023 08:08:45 -0800 [thread overview]
Message-ID: <Y+PJDUo3jsH9WfmB@bombadil.infradead.org> (raw)
In-Reply-To: <Y+HLFWaHq11MQ91U@casper.infradead.org>
On Tue, Feb 07, 2023 at 03:52:53AM +0000, Matthew Wilcox wrote:
> On Mon, Feb 06, 2023 at 06:52:58PM -0800, Luis Chamberlain wrote:
> > shmem_writepage() sets up variables typically used *after* a possible
> > huge page split. However even if that does happen the address space
> > mapping should not change. So it should be safe to set that from
> > the beginning.
>
> Yes, we can get mapping from the folio early. It doesn't change
> on split.
Great.
> > The folio should always be locked from the start as well. It however
> > was not clear if the folio address can / should change, as well as
> > the first inode.
> >
> > This commit makes no functional changes other a double check on the
> > folio locking which might be superflous. This change should help make
> > the subsequent patch easier to review.
>
> You don't need to check that the folio's locked,
That BUG_ON() has been on shmem since linux-history days it's probably
best as a separate patch.
> and you don't
> need to reassign inode after the split.
Great! Thanks for this confirmation!
Luis
next prev parent reply other threads:[~2023-02-08 16:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 2:52 [RFC 0/2] tmpfs: add the option to disable swap Luis Chamberlain
2023-02-07 2:52 ` [RFC 1/2] shmem: set shmem_writepage() variables early Luis Chamberlain
2023-02-07 3:52 ` Matthew Wilcox
2023-02-08 16:08 ` Luis Chamberlain [this message]
2023-02-07 2:52 ` [RFC 2/2] shmem: add support to ignore swap Luis Chamberlain
2023-02-07 4:01 ` Matthew Wilcox
2023-02-08 16:01 ` Luis Chamberlain
2023-02-08 17:45 ` Matthew Wilcox
2023-02-08 20:33 ` Yosry Ahmed
2023-02-23 0:53 ` Luis Chamberlain
2023-02-23 1:04 ` Yosry Ahmed
2023-02-23 1:35 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+PJDUo3jsH9WfmB@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=p.raghav@samsung.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®