From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75811C636D7 for ; Sat, 11 Feb 2023 13:31:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229520AbjBKNa7 (ORCPT ); Sat, 11 Feb 2023 08:30:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbjBKNa5 (ORCPT ); Sat, 11 Feb 2023 08:30:57 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E31D42068F for ; Sat, 11 Feb 2023 05:30:55 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id o15so4517015wrc.9 for ; Sat, 11 Feb 2023 05:30:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=rNl2Kd1xQruZWeNwQkjy47mqA/czch1BygI7D1oDIGk=; b=NypymiZ55VkZtxkoH5z/U4OGmKZ77cRJCJ2ARcdXUJKWbFxkFwylG8nqccGwz66Ldy QaybUIN3PItTTTc9NaWDcIT38O+s1HMOqNofIm9eIEKXHqDiTTeLD35LnwuEK27n1SFR votELwEjqB6upTfl2OLtl7biccV1V6PZfJENzQxPX0q2C1vqlLFu4DavAeY6MKcaiEeI 9V/N+N9pNMD/l0R3PTH4DCffY9GQ19CjGxLtDi2zTr4Hg5CMW6mi7CCH569pEbIsBNk4 c8lIqKZCmCSpDlDUikJPHBsupK+RqBiOnL7W7iI8jVqSO+TZqnXSW8nPifHAmn5HQjGl r/iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rNl2Kd1xQruZWeNwQkjy47mqA/czch1BygI7D1oDIGk=; b=duR6u9p3i5qTEKA2H4RlmF5c6FS/vraJQvRRYD4JA7ZFNeacCnK/BsezbUjktT08aH PSakTGqc4gi7qdfbF8TjIZgkoz9Em+6llpflhM3EanD65mD7VrUf+iKNX/UftBHqyhMQ oZQG5m+d9L6nK7YRpLPalPD6HKWtSAwPS0xdc0uT/5Omb7hu/0m8QNX9yKdbCyC9F55N 85U936C/qCrFMK3mKFRzx4ieutH4guDajNUeLB7cE+VkVBCK1Y1W4xPOh2OoBjzjW8Qh zrmIqVboccu4M+zt4ONs8iLTH44jZZP6p8kiRifsV9J5HyB2obafGsVRjIlWMCvfYV/t tmiA== X-Gm-Message-State: AO0yUKXHfyk7OE6MEy/hgEbx42HXrrSjFF+WLBPpKDdZF373MkFxgUeD JH7me49EQPJItc3p+hIFFQRGfQ== X-Google-Smtp-Source: AK7set/EDcByCs1uVWSz5m9jpWdpI2meYZnoN7/eY1avQr4Ngzd1UY5TyU84+RvEAJp/o+j0yJSBAA== X-Received: by 2002:a05:6000:1811:b0:2c5:4b17:166 with SMTP id m17-20020a056000181100b002c54b170166mr4066156wrh.48.1676122254511; Sat, 11 Feb 2023 05:30:54 -0800 (PST) Received: from localhost (p54ac5802.dip0.t-ipconnect.de. [84.172.88.2]) by smtp.gmail.com with ESMTPSA id t14-20020a05600c198e00b003dff870ce0esm12335853wmq.2.2023.02.11.05.30.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Feb 2023 05:30:53 -0800 (PST) Date: Sat, 11 Feb 2023 14:30:52 +0100 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Wolfram Sang Cc: linux-renesas-soc@vger.kernel.org, Yoshihiro Shimoda , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH RFT 0/3] drivers/thermal/rcar_gen3_thermal: add Gen4 fuse support Message-ID: References: <20230211084728.27832-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230211084728.27832-1-wsa+renesas@sang-engineering.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, Thanks for your work. On 2023-02-11 09:47:24 +0100, Wolfram Sang wrote: > R-Car Gen4 has the fuse registers at different locations and with > different names, but with the same purpose. So, first refactor IP core > differences into a 'info' struct, then add the fuse_read callback to it. > > Patches are based on top of: > > [PATCH v2 0/3] drivers/thermal/rcar_gen3_thermal: Fix device initialization > [PATCH 0/2] thermal: Add support for R-Car V4H > > They have been tested on R-Car H3 ES2.0 and M3-N against regressions. > Actual testing of the new fuses on S4-8 still needs to be done because I > don't have access to such HW. > > @Shimoda-san: maybe the BSP team or Test team can test these patches? > > Looking forward to other review comments, too, of course. For the whole series, Reviewed-by: Niklas Söderlund I boot tested this on V4H, but on that board the fuses where not set so the driver fall-back to the default values. We had a similar situation when we enabled fuses for Gen3. IIRC the BSP team helped out testing that on a board that had the fuses set. > > Happy hacking, > > Wolfram > > > Wolfram Sang (3): > drivers/thermal/rcar_gen3_thermal: introduce 'info' structure > drivers/thermal/rcar_gen3_thermal: refactor reading fuses into > seprarate function > drivers/thermal/rcar_gen3_thermal: add reading fuses for Gen4 > > drivers/thermal/rcar_gen3_thermal.c | 141 ++++++++++++++++++++-------- > 1 file changed, 102 insertions(+), 39 deletions(-) > > -- > 2.30.2 > -- Kind Regards, Niklas Söderlund