From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55C95C636D3 for ; Sun, 12 Feb 2023 11:50:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229627AbjBLLuc (ORCPT ); Sun, 12 Feb 2023 06:50:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjBLLua (ORCPT ); Sun, 12 Feb 2023 06:50:30 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E242B10241; Sun, 12 Feb 2023 03:50:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=F/oUvUqcxxSsH3QTIuSHpDyRj938YvYs4yZVYvuW6Rc=; b=rmaO8vWmZ2RMO07OUH3V7ba7S8 P1CwTAdZQunhfRFsb2o20pzOAlNCcBth+jahyoTS0xevTa+vwncTRpg9rVHO8blya2jZbbjmlQnca lk4pIV887StNb+63EpDyZaZG47FSqzQSTAUXG0raiMj0p3IsrvvzWr17tOl/dA6qRWIRBE0Wh/VaO qhKEh+fo9F6kaeaEHEOl/t6zBISbcYe+taXuuCiReEgJayAy2ZBtIKkZGQWbOKVRqp7EegNcEd+VW ZhvPfav/OSx8HIul7vfUkYWKNG9XWiv48YJ8hLaaT/jDNhPB0srzyLOCwG+Ekys+nqbjbEJw+4beY qhPJc5Hg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRArw-004pM7-BH; Sun, 12 Feb 2023 11:50:08 +0000 Date: Sun, 12 Feb 2023 11:50:08 +0000 From: Matthew Wilcox To: Mike Rapoport Cc: Jonathan Corbet , Andrew Morton , Bagas Sanjaya , David Hildenbrand , Johannes Weiner , Lorenzo Stoakes , Mel Gorman , Michal Hocko , Vlastimil Babka , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] docs/mm: Physical Memory: add example of interleaving nodes Message-ID: References: <20230212095445.1311627-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230212095445.1311627-1-rppt@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 12, 2023 at 11:54:45AM +0200, Mike Rapoport wrote: > +Note, that memory banks may belong to interleaving nodes. In the example > +below an x86 machine has 16Gbytes or RAM in 4 memory banks, even banks > +belong to node 0 and odd banks belong to node 1:: s/or RAM/of RAM/ The "Note," is superfluous, you can just write: Memory banks may belong to interleaved nodes. And I think we prefer the newer form "GiB" for new documentation. > + > + 0 4G 8G 12G 16G > + +-------------+ +-------------+ +-------------+ +-------------+ > + | node 0 | | node 1 | | node 0 | | node 1 | > + +-------------+ +-------------+ +-------------+ +-------------+ > + > + 0 16M 4G > + +-----+-------+ +-------------+ +-------------+ +-------------+ > + | DMA | DMA32 | | NORMAL | | NORMAL | | NORMAL | > + +-----+-------+ +-------------+ +-------------+ +-------------+ > + > +In such case node 0 will span from 0 to 12 Gbytes and node 1 will span from > +4 to 16 Gbytes. s/such/this/ (and I'd use GiB again)