From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Tom Rix <trix@redhat.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
Borislav Petkov <bp@alien8.de>,
tony.luck@intel.com, james.morse@arm.com, mchehab@kernel.org,
rric@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC/amd64: remove unneeded call to reserve_mc_sibling_devs()
Date: Mon, 13 Feb 2023 22:11:38 +0000 [thread overview]
Message-ID: <Y+q1mhrAKTobp3fa@yaz-fattaah> (raw)
In-Reply-To: <03b91ce8-c6d0-63e7-561c-8cada0ece2fe@redhat.com>
On Mon, Feb 13, 2023 at 01:17:51PM -0800, Tom Rix wrote:
>
> On 2/13/23 12:28 PM, Nathan Chancellor wrote:
> > On Mon, Feb 13, 2023 at 09:23:47PM +0100, Borislav Petkov wrote:
> > > On Mon, Feb 13, 2023 at 08:12:38PM +0000, Yazen Ghannam wrote:
> > > > These errors are encountered when extra warnings are enabled, correct?
> > > It says so in the warning which one it is: -Werror,-Wsometimes-uninitialized
> > >
> > > Don't know if we enable that one for clang with W= or Nathan adds
> > > additional switches.
> > -Wsometimes-uninitialized is part of clang's -Wall so it is on by
> > default in all builds, regardless of W=
> >
> > -Werror comes from CONFIG_WERROR, which is enabled with allmodconfig.
> >
> > > > I think the following patch would resolve this issue. This is part of a set
> > > > that isn't fully applied.
> > > > https://lore.kernel.org/linux-edac/20230127170419.1824692-12-yazen.ghannam@amd.com/
> > > >
> > > > Boris,
> > > > Do you think one of these patches should be applied or just hold off until the
> > > > entire original set is applied?
> > > I still wanted to go through the rest but I'm not sure I'll have time
> > > for it before the merge window. So unless this is breaking some silly
> > > testing scenario, I'd say I'll leave things as they are.
> > This breaks allmodconfig with clang, so it would be great if one of
> > these solutions was applied in the meantime.
>
> This happens at least on allyesconfig clang W=1,2, i do not know about
> default, it's in a bad state as well.
>
Yes, this breaks on a default clang build. I just used "make LLVM=1" with the
same config I used before, and I see the error.
GCC doesn't seem to have a comparable warning to "-Wsometimes-uninitialized".
I went back and tried W=123 and no warnings in this code.
Building with clang was straightforward, so I'll try to include it in my
workflow in the future.
> It would be great if the clang build was working.
>
> Nathan's patch is fine, go with that.
>
I agree Nathan's patch is fine, but would you all be okay with a simpler
change? Initializing the variables (as below) will silence the warnings, and
we know this is a false positive. Eventually this function will be reworked,
so a trivial workaround seems okay. What do y'all think?
Thanks,
Yazen
------
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 1c4bef1cdf28..5b42533f306a 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -3928,7 +3928,7 @@ static const struct attribute_group
*amd64_edac_attr_groups[] = {
static int hw_info_get(struct amd64_pvt *pvt)
{
- u16 pci_id1, pci_id2;
+ u16 pci_id1 = 0, pci_id2 = 0;
int ret;
if (pvt->fam >= 0x17) {
------
next prev parent reply other threads:[~2023-02-13 22:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 19:15 Tom Rix
2023-02-13 20:12 ` Yazen Ghannam
2023-02-13 20:23 ` Borislav Petkov
2023-02-13 20:28 ` Nathan Chancellor
2023-02-13 21:17 ` Tom Rix
2023-02-13 22:11 ` Yazen Ghannam [this message]
2023-02-13 22:16 ` Nathan Chancellor
2023-02-14 9:55 ` [PATCH] EDAC/amd64: Shut up an -Werror,-Wsometimes-uninitialized clang false positive Borislav Petkov
2023-02-14 14:32 ` Nathan Chancellor
2023-02-14 15:04 ` Yazen Ghannam
2023-02-14 16:27 ` Nathan Chancellor
2023-02-14 16:38 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+q1mhrAKTobp3fa@yaz-fattaah \
--to=yazen.ghannam@amd.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nathan@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®