mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michael Thalmeier <michael.thalmeier@hale.at>
Cc: Jiri Slaby <jirislaby@kernel.org>,
	Vincent Whitchurch <vincent.whitchurch@axis.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: ttynull: implement console write
Date: Tue, 14 Feb 2023 11:50:33 +0100	[thread overview]
Message-ID: <Y+tneRpVV2KK3Iqy@kroah.com> (raw)
In-Reply-To: <20230214102317.382769-1-michael.thalmeier@hale.at>

On Tue, Feb 14, 2023 at 11:23:17AM +0100, Michael Thalmeier wrote:
> Since commit 3579b59c7edc475013ae769a2d26d99733c95f13 ("printk: refactor

Nit, sha ids should only be 12 digits, as per the kernel documentation,
can you fix that up?

And wait, that's not even a commit id, are you sure that is correct?

> and rework printing logic"), con->write is called without checking if it
> is implemented in the console driver. This does make some sense, because
> for all "normal" consoles it is vital to have a write function.
> As the ttynull console driver does not need any console output the write
> function was not implemented. This caused a "unable to handle kernel NULL
> pointer dereference" when the write function is called now.
> 
> To fix this issue, implement an empty write function.
> 
> Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at>
> Cc: stable@vger.kernel.org

Adding a Fixes: tag here would also be good to have.

thanks,

greg k-h

      reply	other threads:[~2023-02-14 10:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 10:23 Michael Thalmeier
2023-02-14 10:50 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+tneRpVV2KK3Iqy@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.thalmeier@hale.at \
    --cc=vincent.whitchurch@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®