From: Mark Brown <broonie@kernel.org>
To: Frieder Schrempf <frieder@fris.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Marek Vasut <marex@denx.de>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
ChiYuan Huang <cy_huang@richtek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH 4/6] regulator: Add operation to let drivers select vsel register
Date: Tue, 14 Feb 2023 21:06:29 +0000 [thread overview]
Message-ID: <Y+v31bkMWxPEVqrT@sirena.org.uk> (raw)
In-Reply-To: <20230213155833.1644366-5-frieder@fris.de>
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
On Mon, Feb 13, 2023 at 04:58:22PM +0100, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> There are regulators that use multiple registers for storing the
> voltage. Add a get_reg_voltage_sel member to struct regulator_ops in
> order to let drivers register a function that returns the currently
> used register.
>
> The pca9450 driver will be a user of this as the LDO5 regulator of
> that chip uses two different control registers depending on the
> state of an external signal.
Aside from the build warnings the bots reported it's not clear to
me that it's better to do this than it is to just have these
drivers implement appropriate ops directly - there's probably
going to be cases when it's a different bitfield in the same
register, and by the time you've implemented the op so things
aren't completely data driven I'm not sure how much you win by
reusing the register read/write.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-02-14 21:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 15:58 [PATCH 0/6] Use correct LDO5 control registers for PCA9450 Frieder Schrempf
2023-02-13 15:58 ` [PATCH 1/6] dt-bindings: regulator: pca9450: Document new usage of sd-vsel-gpios Frieder Schrempf
2023-02-15 20:02 ` Rob Herring
2023-02-16 1:27 ` Marek Vasut
2023-02-16 2:30 ` Rob Herring
2023-02-16 10:15 ` Frieder Schrempf
2023-02-13 15:58 ` [PATCH 2/6] regulator: pca9450: Fix enable register for LDO5 Frieder Schrempf
2023-02-13 16:12 ` Marek Vasut
2023-02-13 15:58 ` [PATCH 3/6] Revert "regulator: pca9450: Add SD_VSEL GPIO for LDO5" Frieder Schrempf
2023-02-13 16:16 ` Marek Vasut
2023-02-13 16:23 ` Frieder Schrempf
2023-02-13 18:10 ` Marek Vasut
2023-02-13 15:58 ` [PATCH 4/6] regulator: Add operation to let drivers select vsel register Frieder Schrempf
2023-02-14 1:40 ` kernel test robot
2023-02-14 9:19 ` kernel test robot
2023-02-14 21:06 ` Mark Brown [this message]
2023-02-16 9:05 ` Frieder Schrempf
2023-02-16 14:31 ` Mark Brown
2023-02-13 15:58 ` [PATCH 5/6] regulator: pca9450: Fix control register for LDO5 Frieder Schrempf
2023-02-13 15:58 ` [PATCH 6/6] arm64: dts: imx8mm-kontron: Add support for reading SD_VSEL signal Frieder Schrempf
2023-02-13 16:08 ` Marek Vasut
2023-02-13 16:15 ` Frieder Schrempf
2023-02-13 16:15 ` Marco Felsch
2023-02-13 16:18 ` Frieder Schrempf
2023-02-13 21:02 ` Fabio Estevam
2023-02-13 18:12 ` Marek Vasut
2023-02-13 19:56 ` Marco Felsch
2023-02-13 20:59 ` Marek Vasut
2023-02-14 8:10 ` Marco Felsch
2023-02-14 8:26 ` Frieder Schrempf
2023-02-14 11:46 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+v31bkMWxPEVqrT@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=frieder.schrempf@kontron.de \
--cc=frieder@fris.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®