From: Mark Brown <broonie@kernel.org>
To: cy_huang@richtek.com
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
lgirdwood@gmail.com, u0084500@gmail.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: regulator: Add bindings for Richtek RT5739
Date: Wed, 15 Feb 2023 13:03:31 +0000 [thread overview]
Message-ID: <Y+zYIyaWt1tQcUt7@sirena.org.uk> (raw)
In-Reply-To: <1676426457-1389-2-git-send-email-cy_huang@richtek.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
On Wed, Feb 15, 2023 at 10:00:56AM +0800, cy_huang@richtek.com wrote:
> + richtek,vsel-active-high:
> + description: |
> + If property is present, use the 'VSEL1' register group for buck control.
> + Else, use the 'VSEL0' register group. This depends on external hardware
> + 'VSEL' pin connecton.
> + type: boolean
I would expect this to be GPIO controlled rather than fixed in
the design, at least for some systems? The name suggests it's
supposed to control the polarity of a GPIO too. Sadly we don't
really have good infrastructure for fixed GPIOs AFAIK... ideally
this would be a GPIO and then if we need to hold it high then
there would be some binding we could connect to the GPIO that
says that. We don't have that though so for now a fixed property
might be OK.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-02-15 13:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 2:00 [PATCH 0/2] Add Richtek RT5739 switching voltage regulator support cy_huang
2023-02-15 2:00 ` [PATCH 1/2] dt-bindings: regulator: Add bindings for Richtek RT5739 cy_huang
2023-02-15 13:03 ` Mark Brown [this message]
2023-02-15 13:30 ` ChiYuan Huang
2023-02-16 9:12 ` Krzysztof Kozlowski
2023-02-16 9:57 ` ChiYuan Huang
2023-02-16 10:03 ` Krzysztof Kozlowski
2023-02-16 10:35 ` ChiYuan Huang
2023-02-16 10:45 ` Krzysztof Kozlowski
2023-02-15 2:00 ` [PATCH 2/2] regulator: Add support for Richtek RT5739 voltage regulator cy_huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+zYIyaWt1tQcUt7@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=u0084500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®