From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Claudiu.Beznea@microchip.com
Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com,
linus.walleij@linaro.org, Nicolas.Ferre@microchip.com,
alexandre.belloni@bootlin.com
Subject: Re: [PATCH v2 5/5] pinctrl: at91: Utilise temporary variable for struct device
Date: Wed, 15 Feb 2023 15:38:06 +0200 [thread overview]
Message-ID: <Y+zgPjDruv4cIqDd@smile.fi.intel.com> (raw)
In-Reply-To: <b78661b9-d9a4-5c2c-7df6-8fc79da73538@microchip.com>
On Tue, Feb 14, 2023 at 11:11:58AM +0000, Claudiu.Beznea@microchip.com wrote:
> On 13.02.2023 17:45, Andy Shevchenko wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > We have a temporary variable to keep pointer to struct device.
> > Utilise it inside the ->probe() implementation.
>
> Apart from this the patch also removes some { } and does some alignments.
> For clarity some of these might go better in a different patch.
I was under impression that checkpatch will complain about it, but it appears
that it does not. I will issue a new version with this updated.
Thanks for your reviews and testing!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-02-15 13:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 15:45 [PATCH v2 0/5] pinctrl: at91: Cleanups Andy Shevchenko
2023-02-13 15:45 ` [PATCH v2 1/5] pinctrl: at91: use devm_kasprintf() to avoid potential leaks (part 2) Andy Shevchenko
2023-02-14 11:05 ` Claudiu.Beznea
2023-02-13 15:45 ` [PATCH v2 2/5] pinctrl: at91: Don't mix non-devm calls with devm ones Andy Shevchenko
2023-02-14 11:05 ` Claudiu.Beznea
2023-02-13 15:45 ` [PATCH v2 3/5] pinctrl: at91: Use of_device_get_match_data() Andy Shevchenko
2023-02-14 11:05 ` Claudiu.Beznea
2023-02-13 15:45 ` [PATCH v2 4/5] pinctrl: at91: Use dev_err_probe() instead of custom messaging Andy Shevchenko
2023-02-14 11:07 ` Claudiu.Beznea
2023-02-13 15:45 ` [PATCH v2 5/5] pinctrl: at91: Utilise temporary variable for struct device Andy Shevchenko
2023-02-14 11:11 ` Claudiu.Beznea
2023-02-15 13:38 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+zgPjDruv4cIqDd@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®