mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org, Daniel Mack <daniel@zonque.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>
Subject: Re: [PATCH v1 3/6] spi: pxa2xx: Remove no more needed PCI ID table
Date: Mon, 17 Oct 2022 18:39:19 +0100	[thread overview]
Message-ID: <Y02TR0UBseEKUjq8@sirena.org.uk> (raw)
In-Reply-To: <Y02SVH04iiu7Rj+8@smile.fi.intel.com>

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

On Mon, Oct 17, 2022 at 08:35:16PM +0300, Andy Shevchenko wrote:
> On Mon, Oct 17, 2022 at 06:18:38PM +0100, Mark Brown wrote:
> > On Mon, Oct 17, 2022 at 08:12:40PM +0300, Andy Shevchenko wrote:

> > > Since the PCI enumerated devices provide a property with SSP type,
> > > there is no more necessity to bear the copy of the ID table here.
> > > Remove it for good.

> > They do?  How?  Are you sure that this is true for all existing devices?

> Currently the board code assures that the property is always there for all
> existing devices.

Which board code is this?  The names of the new properties you're adding
is really not at all idiomatic for ACPI and this is pretty old code so
it's surprising that there's not existing systems that don't have this
in their BIOSs.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-10-17 17:39 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 17:12 [PATCH v1 1/6] spi: pxa2xx: Simplify with devm_platform_get_and_ioremap_resource() Andy Shevchenko
2022-10-17 17:12 ` [PATCH v1 2/6] spi: pxa2xx: Respect Intel SSP type given by a property Andy Shevchenko
2022-10-17 17:17   ` Mark Brown
2022-10-17 17:34     ` Andy Shevchenko
2022-10-17 17:12 ` [PATCH v1 3/6] spi: pxa2xx: Remove no more needed PCI ID table Andy Shevchenko
2022-10-17 17:18   ` Mark Brown
2022-10-17 17:35     ` Andy Shevchenko
2022-10-17 17:39       ` Mark Brown [this message]
2022-10-17 17:41         ` Andy Shevchenko
2022-10-18 11:42           ` Mark Brown
2022-10-19 15:06             ` Andy Shevchenko
2022-10-19 15:50               ` Mark Brown
2022-10-20 16:18                 ` Andy Shevchenko
2022-10-20 16:25                   ` Mark Brown
2022-10-20 16:42                     ` Andy Shevchenko
2022-10-20 16:58                       ` Mark Brown
2022-10-20 17:03                         ` Andy Shevchenko
2022-10-20 17:26                           ` Mark Brown
2022-10-20 17:41                             ` Andy Shevchenko
2022-10-20 17:45                               ` Mark Brown
2022-10-20 17:55                                 ` Andy Shevchenko
2022-10-20 18:07                                   ` Mark Brown
2022-10-20 18:19                                     ` Andy Shevchenko
2022-10-21 10:42                                       ` Mark Brown
2022-10-21 10:51                                         ` Andy Shevchenko
2022-10-21 10:59                                           ` Mark Brown
2022-10-21 11:15                                             ` Andy Shevchenko
2022-10-21 12:28                                               ` Mark Brown
2022-10-21 12:46                                                 ` Andy Shevchenko
2022-10-17 17:42         ` Mark Brown
2022-10-17 17:12 ` [PATCH v1 4/6] spi: pxa2xx: Remove no more needed driver data Andy Shevchenko
2022-10-17 17:12 ` [PATCH v1 5/6] spi: pxa2xx: Move OF and ACPI ID tables closer to their user Andy Shevchenko
2022-10-18  9:16   ` Jonathan Cameron
2022-10-17 17:12 ` [PATCH v1 6/6] spi: pxa2xx: Switch from PM ifdeffery to pm_ptr() Andy Shevchenko
2022-10-17 17:19   ` Mark Brown
2022-10-17 17:35     ` Andy Shevchenko
2022-10-18  9:14   ` Jonathan Cameron
2022-10-18 12:23     ` Andy Shevchenko
2022-10-19 12:05 ` (subset) [PATCH v1 1/6] spi: pxa2xx: Simplify with devm_platform_get_and_ioremap_resource() Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y02TR0UBseEKUjq8@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=daniel@zonque.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®