From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D06D0C433FE for ; Tue, 18 Oct 2022 14:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230164AbiJROfM (ORCPT ); Tue, 18 Oct 2022 10:35:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231297AbiJROfJ (ORCPT ); Tue, 18 Oct 2022 10:35:09 -0400 Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 018B59F342 for ; Tue, 18 Oct 2022 07:35:04 -0700 (PDT) Received: (qmail 1214035 invoked by uid 1000); 18 Oct 2022 10:35:03 -0400 Date: Tue, 18 Oct 2022 10:35:03 -0400 From: Alan Stern To: Vadym Kochan Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Elad Nachman Subject: Re: [PATCH v2] usb: ehci-orion: Extend DMA mask to 64 bit for AC5 platform Message-ID: References: <20221018113401.32229-1-vadym.kochan@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221018113401.32229-1-vadym.kochan@plvision.eu> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2022 at 02:34:00PM +0300, Vadym Kochan wrote: > From: Elad Nachman > > AC5 is a 64-bit platform so extend the dma mask accordingly. > > Checked this mask on armv7 a38x SoC (which has this > USB controller) platform with simple fs ops on the storage device > but on older 4.14 Linux version. > > Signed-off-by: Elad Nachman > Signed-off-by: Vadym Kochan > --- > v2: > Add missing description. > > drivers/usb/host/ehci-orion.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c > index a3454a3ea4e0..c6205abebbdf 100644 > --- a/drivers/usb/host/ehci-orion.c > +++ b/drivers/usb/host/ehci-orion.c > @@ -230,7 +230,7 @@ static int ehci_orion_drv_probe(struct platform_device *pdev) > * set. Since shared usb code relies on it, set it here for > * now. Once we have dma capability bindings this can go away. > */ > - err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); > + err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); > if (err) > goto err; > NAK. The description says this changes the DMA mask on AC5 platforms to 64 bits, but that isn't what the patch actually does. It changes the DMA mask on _all_ platforms using the orion hardware. Alan Stern