From: Mark Brown <broonie@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, peterz@infradead.org,
acme@kernel.org, mark.rutland@arm.com, will@kernel.org,
catalin.marinas@arm.com, James Clark <james.clark@arm.com>,
Rob Herring <robh@kernel.org>, Marc Zyngier <maz@kernel.org>,
Suzuki Poulose <suzuki.poulose@arm.com>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH V4 1/7] arm64/perf: Add BRBE registers and fields
Date: Tue, 18 Oct 2022 14:56:24 +0100 [thread overview]
Message-ID: <Y06wiI2hgsz5QPTh@sirena.org.uk> (raw)
In-Reply-To: <20221017055713.451092-2-anshuman.khandual@arm.com>
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
On Mon, Oct 17, 2022 at 11:27:07AM +0530, Anshuman Khandual wrote:
I spotted one typo below but otherwise this looks good!
> +# This is just a dummy register declaration to get all common field masks and
> +# shifts for accessing given BRBINF contents.
> +Sysreg BRBINF_EL1 2 1 8 0 0
This seems reasonable to me, others may disagree.
> +Sysreg BRBCR_EL1 2 1 9 0 0
> +Res0 63:24
> +Field 23 EXCEPTION
> +Field 22 ERTN
> +Res0 21:9
> +Field 8 FZP
> +Res0 7
> +Enum 6:5 TS
> + 0b1 VIRTUAL
I'd have expected this to be written as 0b01. Doesn't make any
practical difference though.
> +Sysreg BRBFCR_EL1 2 1 9 0 1
> +Field 16 EnL
This is "EnI" in DDI0487I.a.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-10-18 13:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 5:57 [PATCH V4 0/7] arm64/perf: Enable branch stack sampling Anshuman Khandual
2022-10-17 5:57 ` [PATCH V4 1/7] arm64/perf: Add BRBE registers and fields Anshuman Khandual
2022-10-18 13:56 ` Mark Brown [this message]
2022-10-19 3:01 ` Anshuman Khandual
2022-10-17 5:57 ` [PATCH V4 2/7] arm64/perf: Update struct arm_pmu for BRBE Anshuman Khandual
2022-10-17 5:57 ` [PATCH V4 3/7] arm64/perf: Update struct pmu_hw_events " Anshuman Khandual
2022-10-17 5:57 ` [PATCH V4 4/7] driver/perf/arm_pmu_platform: Add support for BRBE attributes detection Anshuman Khandual
2022-10-17 5:57 ` [PATCH V4 5/7] arm64/perf: Drive BRBE from perf event states Anshuman Khandual
2022-10-17 5:57 ` [PATCH V4 6/7] arm64/perf: Add BRBE driver Anshuman Khandual
2022-11-02 15:36 ` James Clark
2022-11-07 2:41 ` Anshuman Khandual
2022-10-17 5:57 ` [PATCH V4 7/7] arm64/perf: Enable branch stack sampling Anshuman Khandual
2022-10-27 2:51 ` [PATCH V4 0/7] " Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y06wiI2hgsz5QPTh@sirena.org.uk \
--to=broonie@kernel.org \
--cc=acme@kernel.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.clark@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®