From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A52DDC4332F for ; Tue, 18 Oct 2022 15:47:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231126AbiJRPrU (ORCPT ); Tue, 18 Oct 2022 11:47:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229971AbiJRPrR (ORCPT ); Tue, 18 Oct 2022 11:47:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF52DC14A5; Tue, 18 Oct 2022 08:47:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A2306615D3; Tue, 18 Oct 2022 15:47:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2F73C433D7; Tue, 18 Oct 2022 15:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666108034; bh=qcKyENMx6mTmZ0TU9r5WLxS2rM0ANcBloLaQCW9lMtI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qFi1Cd9XrbdgMzYwbGl4PpeXf9TywiyD/tym7bUZFa0kqOiJLEWRrHv/uMUWjPQpW cbP0etVbeG0b0t6fwTSu5WRCiqGj1yr9KvbyQYUiWSdqrvmQIMFxMMCsWw88sJtayj aIjiU8+WM+3QAWo3YzBWq7JZWevaBFNhFWcpBs2cyxWyxC3MsbBmDglXAlhz8p/lq+ Tq4UdU6eHQuv97yZk3R47af/6g5RsH6HLNzTg5Ma/XlX8wsGx+bDRaGqd4ueiMQoDS dyMSOAXV6v0G/Mis30/70XcoNfBlUnhRftp1QIHKvFw0cK4xZbvhr4hHLbh+fSCUTI IA9fEDh46Y6Ug== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1okoo2-00062o-FW; Tue, 18 Oct 2022 17:47:02 +0200 Date: Tue, 18 Oct 2022 17:47:02 +0200 From: Johan Hovold To: Krzysztof Kozlowski Cc: Johan Hovold , Vinod Koul , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/15] dt-bindings: phy: qcom,qmp-pcie: add sc8280xp bindings Message-ID: References: <20221017145328.22090-1-johan+linaro@kernel.org> <20221017145328.22090-11-johan+linaro@kernel.org> <7a2b1617-5e57-994e-a246-2e6f9fd69262@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7a2b1617-5e57-994e-a246-2e6f9fd69262@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2022 at 11:22:13AM -0400, Krzysztof Kozlowski wrote: > On 18/10/2022 05:40, Johan Hovold wrote: > > On Mon, Oct 17, 2022 at 01:20:49PM -0400, Krzysztof Kozlowski wrote: > >> On 17/10/2022 10:53, Johan Hovold wrote: > >>> Add bindings for the PCIe QMP PHYs found on SC8280XP. > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml > >> > >> Filename based on compatible, so for example: > >> > >> qcom,sc8280xp-qmp-pcie-phy.yaml > > > > Ok, but as I mentioned in my reply to the previous patch, this file is > > the one that is expected to be extended with new bindings. > > I would still propose to use compatible of this series and treat it as a > family name of compatible or similar devices. What other choice we have? > > If new (third) PHY bindings appear, then rename older to "-legacies" and > this one to "-legacy"? We could also continue using qcom,qmp-pcie-phy.yaml for the latest generic binding were new devices should be added and rename the "deprecated" ones after one of the compatibles to make it sound less generic. But I get your point. > > I can't seem to find where this naming scheme is documented now even if > > I'm quite sure I've seen it before. Do you have a pointer? > > If you need the source of authority, then: > https://lore.kernel.org/linux-devicetree/YlhkwvGdcf4ozTzG@robh.at.kernel.org/ > > If you need unofficial documentation, then slides here: > https://osseu2022.sched.com/event/15z0W > > If you need something official, that's on TODO list. :) Heh. Ok. > > And does this imply that the file name should also include the gen infix > > of one of the original compatibles (e.g. > > "qcom,sc8280xp-qmp-gen3x4-pcie-phy.yaml")? > > Since you already have here three compatibles, you cannot have one > filename matching exactly all of them, so we already accept something > generic. Therefore I proposed the common part - matching SoC component. Yeah, that's what I was alluding too. As soon you add one more SoC to the same document, the common part is no longer qcom,sc8280xp-qmp-pcie-phy but rather qcom,qmp-pcie-phy Johan