From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C065C4332F for ; Tue, 18 Oct 2022 17:41:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229875AbiJRRlu (ORCPT ); Tue, 18 Oct 2022 13:41:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230123AbiJRRlr (ORCPT ); Tue, 18 Oct 2022 13:41:47 -0400 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EACE119C02 for ; Tue, 18 Oct 2022 10:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666114898; bh=6nlFqTQIDFJBZON/b1YWt8WoagF5LhXfRTGzet31JT8=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=dIuSi6cL/PyF0+MakRmAc5t7j6YXHYmGlwpcXPmLfEDU02IrZ1/t0lYNDQ/h70sTs xT6coU5Xqg/RW0fcRMAqK3p3gJ8i2FudZAoNZsqabY8ztgDQULd4waFiku4P9dX2ZS q19peJyg7N3pr+L1gv0XmS31btxkI6p+9AFc5a/M= Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP via [213.182.55.206] Tue, 18 Oct 2022 19:41:37 +0200 (CEST) X-EA-Auth: 2K/3isRMWv89QB7+MFBNbojKPj0XdVa9VUsChrj+h2BOrKk05czs9l7TjgbZB7J9X6ly9TolhKJxq0Y83K7EPpUhwFMrNMdS Date: Tue, 18 Oct 2022 23:11:34 +0530 From: Deepak R Varma To: Julia Lawall Cc: outreachy@lists.linux.dev, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: most: dim2: correct misleading variable name Message-ID: References: <66e6d6f-3574-e317-946e-2c2467726eab@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66e6d6f-3574-e317-946e-2c2467726eab@inria.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2022 at 06:59:59PM +0200, Julia Lawall wrote: > > > On Tue, 18 Oct 2022, Deepak R Varma wrote: > > > Correct misleading struct variable name dim_ch_state_t to dim_ch_state > > since this not a typedef but a normal variable declaration. > > Actually, it's not the name of a variable, but the name of a type. oops.. my bad. I will wait for any other feedback on this patch set and accordingly send in the revision. Thank you, ./drv > > julia > > > > > Suggested-by: Julia Lawall > > Signed-off-by: Deepak R Varma > > --- > > drivers/staging/most/dim2/dim2.c | 2 +- > > drivers/staging/most/dim2/hal.c | 4 ++-- > > drivers/staging/most/dim2/hal.h | 6 +++--- > > 3 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > > index 4c1f27898a29..a69a61a69283 100644 > > --- a/drivers/staging/most/dim2/dim2.c > > +++ b/drivers/staging/most/dim2/dim2.c > > @@ -161,7 +161,7 @@ static int try_start_dim_transfer(struct hdm_channel *hdm_ch) > > struct list_head *head = &hdm_ch->pending_list; > > struct mbo *mbo; > > unsigned long flags; > > - struct dim_ch_state_t st; > > + struct dim_ch_state st; > > > > BUG_ON(!hdm_ch); > > BUG_ON(!hdm_ch->is_initialized); > > diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c > > index 65282c276862..a5d40b5b138a 100644 > > --- a/drivers/staging/most/dim2/hal.c > > +++ b/drivers/staging/most/dim2/hal.c > > @@ -943,8 +943,8 @@ u8 dim_service_channel(struct dim_channel *ch) > > return channel_service(ch); > > } > > > > -struct dim_ch_state_t *dim_get_channel_state(struct dim_channel *ch, > > - struct dim_ch_state_t *state_ptr) > > +struct dim_ch_state *dim_get_channel_state(struct dim_channel *ch, > > + struct dim_ch_state *state_ptr) > > { > > if (!ch || !state_ptr) > > return NULL; > > diff --git a/drivers/staging/most/dim2/hal.h b/drivers/staging/most/dim2/hal.h > > index 20531449acab..ef10a8741c10 100644 > > --- a/drivers/staging/most/dim2/hal.h > > +++ b/drivers/staging/most/dim2/hal.h > > @@ -27,7 +27,7 @@ enum mlb_clk_speed { > > CLK_8192FS = 7, > > }; > > > > -struct dim_ch_state_t { > > +struct dim_ch_state { > > bool ready; /* Shows readiness to enqueue next buffer */ > > u16 done_buffers; /* Number of completed buffers */ > > }; > > @@ -87,8 +87,8 @@ void dim_service_ahb_int_irq(struct dim_channel *const *channels); > > > > u8 dim_service_channel(struct dim_channel *ch); > > > > -struct dim_ch_state_t *dim_get_channel_state(struct dim_channel *ch, > > - struct dim_ch_state_t *state_ptr); > > +struct dim_ch_state *dim_get_channel_state(struct dim_channel *ch, > > + struct dim_ch_state *state_ptr); > > > > u16 dim_dbr_space(struct dim_channel *ch); > > > > -- > > 2.30.2 > > > > > > > > > > >