From: Mark Brown <broonie@kernel.org>
To: Siarhei Volkau <lis8215@gmail.com>
Cc: Paul Cercueil <paul@crapouillou.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-mips@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: jz4725b: Various improvements and fixes
Date: Mon, 10 Oct 2022 16:53:35 +0100 [thread overview]
Message-ID: <Y0Q//+onKu16VQKH@sirena.org.uk> (raw)
In-Reply-To: <CAKNVLfZhH3s=jBWAoSppXSotY9giRRJbub9MqxCtjdZKh4fprg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On Mon, Oct 10, 2022 at 06:20:24PM +0300, Siarhei Volkau wrote:
> пн, 10 окт. 2022 г. в 14:19, Mark Brown <broonie@kernel.org>:
> > and will presumably cause problems for any existing configurations...
> I'm curious why this didn't cause problems earlier, as the wrong
> control was used
> for the Master Capture Volume.
The issue is that if someone is relying on the current behaviour and the
control starts doing something completely different they might be
surprised, it at least needs a separate change.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-10-10 15:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 18:16 Siarhei Volkau
2022-10-10 11:19 ` Mark Brown
2022-10-10 15:20 ` Siarhei Volkau
2022-10-10 15:53 ` Mark Brown [this message]
2022-10-10 16:26 ` Siarhei Volkau
2022-10-10 18:54 ` [PATCH v2 0/6] " Siarhei Volkau
2022-10-10 18:54 ` [PATCH v2 1/6] ASoC: codecs: jz4725b: add missed Line In power control bit Siarhei Volkau
2022-10-10 18:54 ` [PATCH v2 2/6] ASoC: codecs: jz4725b: fix reported volume for Master ctl Siarhei Volkau
2022-10-10 18:54 ` [PATCH v2 3/6] ASoC: codecs: jz4725b: use right control for Capture Volume Siarhei Volkau
2022-10-10 18:54 ` [PATCH v2 4/6] ASoC: codecs: jz4725b: fix capture selector naming Siarhei Volkau
2022-10-10 18:54 ` [PATCH v2 5/6] ASoC: codecs: jz4725b: use right control for Master Playback Siarhei Volkau
2022-10-10 18:54 ` [PATCH v2 6/6] ASoC: codecs: jz4725b: add missed Mixer inputs Siarhei Volkau
2022-10-18 11:28 ` [PATCH v2 0/6] ASoC: codecs: jz4725b: Various improvements and fixes Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0Q//+onKu16VQKH@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lis8215@gmail.com \
--cc=paul@crapouillou.net \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®