From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE4CAC43217 for ; Mon, 10 Oct 2022 13:10:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229721AbiJJNKB (ORCPT ); Mon, 10 Oct 2022 09:10:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbiJJNJ6 (ORCPT ); Mon, 10 Oct 2022 09:09:58 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D05F02EF13; Mon, 10 Oct 2022 06:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gyIX3AzIymxYoNriDmltRqIhXboTWSwCFq+wUsDyIZQ=; b=gGOCd3YeFdaBwBl2MW+tnd5r55 LgaxTyufuAidu0AxR29dCeciklDBoOZGaiFhqGu19IBonngzt9KXrRM662lnI6mBvAC48taBAVOYP 6mWug9b2g3foLMROliBcOrWV84P5XlEVt6v6+80ADZt/urX1RxDbjAByE7ja8U2jDoywfxZDScA42 HLpFMfaKi3L6Sq9u80PWor0KDB1wwzYuu6k9X6n/PKQK/qxO5OR6OPCsnexhIN3fh6Sj1i54igEr9 yVvVQeXA8MsNeuQMQzo/t+lsnSrB6SbiQkCAi9LvaHlItgGOrfDd1nRUDHOQ3HvTJcaPL94g12H0f 1DIzYvvw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohsXP-000y8l-TY; Mon, 10 Oct 2022 13:09:43 +0000 Date: Mon, 10 Oct 2022 06:09:43 -0700 From: Christoph Hellwig To: "zhaoyang.huang" Cc: Andrew Morton , Matthew Wilcox , Vlastimil Babka , Zhaoyang Huang , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com, steve.kang@unisoc.com Subject: Re: [RFC PATCH] mm: skip GFP_IO if swap is zram only Message-ID: References: <1665399622-20236-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1665399622-20236-1-git-send-email-zhaoyang.huang@unisoc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 10, 2022 at 07:00:22PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > __GFP_IO is believed to prevent the allocation being suspended due to accessing > physical block devices when reclaiming dirty pages. Zram is not considered as > such kind of device from kernel perspective of view. Do swap things if the system > is zram only. No, zram is not in any way special, and for sure not important enough to add special case hacks to the VM code.