From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D587C433FE for ; Tue, 11 Oct 2022 14:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229613AbiJKOVW (ORCPT ); Tue, 11 Oct 2022 10:21:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbiJKOVT (ORCPT ); Tue, 11 Oct 2022 10:21:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE33C923F1; Tue, 11 Oct 2022 07:21:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7B162B81620; Tue, 11 Oct 2022 14:21:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D325C433C1; Tue, 11 Oct 2022 14:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665498075; bh=Uw7HGYkOrkomzkADPrKZvJ35Fxs2ojCfT+PTAwSqXuY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mXw0FpxB4UieVbku/lpyTy/KLulq2zn7OdKkkDbIqhlaBUfMOICqQtkUy2WaV3pnB R5Sad5dbAuJqxuYSPmJpGTAw8gBbKprAvZvD0+vNgyK/+s/+EiGEF8j26JCQJLuC84 wRtkN5HUG+/HvqeXpIvgyFivtfVLmob5XMHcX84FbcAvUXTeHmoI71zKPs1bgrBaP5 +uKPbVjaXQeHfy+7gg5HK7G09v4QoOVojw8KkOvrNvsZzwhFqNVAucLxQMNpjxIaX5 H9vSrqiLYLB2TFIE26Nnr2C7XVw86oR6Sne5qJvfMSdnDzIljXX6arjq4985gIxmoA tAaw/shN0yYNg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oiG82-0003Cu-6d; Tue, 11 Oct 2022 16:21:06 +0200 Date: Tue, 11 Oct 2022 16:21:06 +0200 From: Johan Hovold To: Dmitry Baryshkov Cc: Johan Hovold , Vinod Koul , Andy Gross , Bjorn Andersson , Konrad Dybcio , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/13] phy: qcom-qmp-combo: drop sc8280xp power-down delay Message-ID: References: <20221011131416.2478-1-johan+linaro@kernel.org> <20221011131416.2478-11-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 11, 2022 at 05:07:16PM +0300, Dmitry Baryshkov wrote: > On 11/10/2022 16:14, Johan Hovold wrote: > > The SC8280XP combo PHY does not need a delay before starting the USB PHY > > (which is what the has_pwrdn_delay config option really controls) so > > drop the unnecessary delay. > > > > Signed-off-by: Johan Hovold > > --- > > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 4 ---- > > 1 file changed, 4 deletions(-) > > Just an obvious question: 'does not need a delay' comes from your > experience or from some vendor flag (in ACPI/DT/kernel/wherever)? There's no corresponding delay in the vendor driver; the delay as it is used in the driver (before starting the PHY) makes no sense and shouldn't be used for new platforms; and I've verified that it isn't needed on SC8280XP. I'm confident that this was just another case of copy-pasting. And the buck stops here (with SC8280XP). ;) Johan