From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A871C43217 for ; Tue, 11 Oct 2022 10:36:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229768AbiJKKgW (ORCPT ); Tue, 11 Oct 2022 06:36:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbiJKKgT (ORCPT ); Tue, 11 Oct 2022 06:36:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF6E35F7C0; Tue, 11 Oct 2022 03:36:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5F97061170; Tue, 11 Oct 2022 10:36:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86D46C433C1; Tue, 11 Oct 2022 10:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665484577; bh=AcvorbeO7IeezbFs7GQqmszANLwT9CFP0PPWa4yQhSY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XScz9NDzzIDweBEQWQD6uEatQsLYoKNf0V2UUAz2Ok8Vh+bpNmD5bHaErD5CDQJ0z +A8MwfoSbbgfkfVagPurQwVWzBaBDkBr1Po5IklakKfXI7qc2a3O4dRXyfWvke+eZz vu+HXDH+Mltm90I8gKbr6jDua8NFm3FQxU5FKz9mgA1+CC3Jy/591280vpYuUb3aee l3DAZh3esPC9S+P+5u+hZOnHi1Jf8mGdnImnKZFGH+1K/VCZDwsum4QOIOKICYbp+a ChGvxntxgOXD0nEEABwPgkmunMwXZx70XwQYwJDjfvsxqnveR6VRg5XFUfcWRGfbzq EK8gnpHkbj2zw== Date: Tue, 11 Oct 2022 11:36:10 +0100 From: Mark Brown To: Alexandre Mergnat Cc: krzysztof.kozlowski@linaro.org, chen.zhong@mediatek.com, devicetree@vger.kernel.org, dmitry.torokhov@gmail.com, fparent@baylibre.com, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, robh+dt@kernel.org, robh@kernel.org Subject: Re: [PATCH v2 3/5] dt-bindings: regulator: Add binding schema for mt6357 regulators Message-ID: References: <972ba839-2fd3-2b45-3477-0c7e3d32f149@baylibre.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Qy+sdSDVmD8xz5a1" Content-Disposition: inline In-Reply-To: <972ba839-2fd3-2b45-3477-0c7e3d32f149@baylibre.com> X-Cookie: I had pancake makeup for brunch! Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Qy+sdSDVmD8xz5a1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 11, 2022 at 11:30:58AM +0200, Alexandre Mergnat wrote: > > Why enforcing particular name of the regulator? > The regulator names are forced to match with the datasheet names. > I think it's a good practice to increase visibility between HW & SW. > Also, that keep consistency with other Mediatek PMIC schema. No, this is bad practice which completely misses the point of what the names are for and the other Mediatek drivers are broken. --Qy+sdSDVmD8xz5a1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmNFRxkACgkQJNaLcl1U h9DNVAf+IAfeWJtE4IzcYAbU8KiaUeVALAXjWr2ios39H9Rp6rmG3HbUm0Hn4YQ7 z6mOZsA/dxM0GBcC+0E4GaJBb9nPdNcsm5he5cnG53JCzLZEli8b5hd+d4vrhtai PSNcNlwd5gr4bBnISeOXqsmHy1VvwkGpJuo84sA4Rre//0tocfPmJX8i+tINms4k MfSgehyBSxsGwFFwxo8sxFrR/mP1zsTe+XQKZ/pPaQHI/2/OfxSuUzn8qtCI3g1X ySN2o41nmq+Jg7CWmAXQnQuTa5b3CBGW0bCRb6x728A/+VSHaNKp4fU4VcfalpeW LDQ7MYIWTvgZK3ffGffopei5AOipng== =QZoS -----END PGP SIGNATURE----- --Qy+sdSDVmD8xz5a1--